mailchimp-api icon indicating copy to clipboard operation
mailchimp-api copied to clipboard

Looks like unit tests are not working using travis

Open slavielle opened this issue 6 years ago • 2 comments

Hello, I noticed something wrong about your unit tests playing on Travis :

If you click on the "passed" badge you can see on travis (https://travis-ci.org/drewm/mailchimp-api) that tests fails on PHP 5.4, 5.5 and 5.6 (because of a missing .env file) and are passing on PHP 7, 7.1 and 7.2.

But if you go on the job page where test passes (example https://travis-ci.org/drewm/mailchimp-api/jobs/308344530) you can see "No tests executed!".

Your test badge is hence displaying a false "passing".

slavielle avatar Nov 28 '17 12:11 slavielle

They're set in the Travis environment directly. From the build output just now:

Setting environment variables from repository settings
$ export MC_API_KEY=[secure]
$ export MC_LIST_ID=[secure]

and then finally:

1.18s$ phpunit
PHPUnit 4.8.35 by Sebastian Bergmann and contributors.
.......
Time: 1.08 seconds, Memory: 16.25MB
OK (7 tests, 7 assertions)

drewm avatar Nov 28 '17 12:11 drewm

Yep, see that, its working now for PHP 5.4, 5.5 and 5.6. You know why tests are not playing on PHP 7+ versions ?

slavielle avatar Nov 28 '17 12:11 slavielle