npcdialog icon indicating copy to clipboard operation
npcdialog copied to clipboard

Can't use on MCBE 1.17.10 with 3.22.0 PocketMine-MP

Open quydrop opened this issue 4 years ago • 4 comments

NPC Form can't use on 1.17.20 version, i think because of this update SmartSelect_20210716-113403_Chrome Can you update it, please?

quydrop avatar Jul 16 '21 04:07 quydrop

Please, update it :(((

quydrop avatar Jul 25 '21 20:07 quydrop

Can you please update the plugin ? I'm having the same issue..

Julooooooos avatar Jul 29 '21 06:07 Julooooooos

you can wait, this problem cannot be solved, as this is a minecraft bug.
the generous thebigsmileXD provided information on this https://bugs.mojang.com/browse/MCPE-135686

ananinys avatar Jul 29 '21 19:07 ananinys

solved ?

royaljacques avatar Nov 22 '21 00:11 royaljacques

you can wait, this problem cannot be solved, as this is a minecraft bug. the generous thebigsmileXD provided information on this bugs.mojang.com/browse/MCPE-135686

i don't think that bug is actually the issue here. I am pretty much struggling to get the forms to show in 1.19.2, and i am not sure if it is the game, the packet or my pull request that messed it up. I know for sure that they work fine in singleplayer.

inxomnyaa avatar Jan 23 '23 18:01 inxomnyaa

Update on this, Galaxite and NetherGames have them still functioning, both use it.

  • The interaction or action tag is not needed anymore, it's handled directly by the packet
  • The server initiates the opening of the form
  • I tried sending the opening form, i don't get a packet violation anymore.. nor a crash.. at least currently. But the form still won't show.
  • The InteractPacket::NPC_OPEN doesn't seem to be sent either..

inxomnyaa avatar Mar 03 '23 18:03 inxomnyaa

Got it working. Forms must be opened by the server now. Since the InteractPacket is broken, i handle PlayerEntityInteractEvent instead, and then open a form, restoring the old functionality. Still have some leftover debug in the code, but button clicks and everything else is working properly now. Also added some extra functionality like an open listener. https://github.com/WolvesFortress/NpcDialog/commit/d43f216cf338222eee5f2532d34c2714f859f47d

inxomnyaa avatar Mar 05 '23 10:03 inxomnyaa

The @WolvesFortress fork has been merged and thus resolved this issue.

inxomnyaa avatar Sep 12 '23 07:09 inxomnyaa