deconz-rest-plugin icon indicating copy to clipboard operation
deconz-rest-plugin copied to clipboard

Add DDF for a Tuya TRV _TZE200_hhrtiq0x , and prepare the code to use it

Open Smanar opened this issue 2 years ago • 6 comments

So with the @TheHaf 's help, the first working tuya trv with DDF

The code is working but still have 2 issues :

  • the valve position is not working, but for the moment the tuya return is not visible in log (so perhaps not supported by this device) ~~- Not possible to use "script" for "write" part, only "eval" is working.~~

If you want to help there is a version with more debug lines on the issue https://github.com/dresden-elektronik/deconz-rest-plugin/issues/5831

Smanar avatar May 14 '22 19:05 Smanar

For the moment I m the only one that use it for tuya so I m using

StateChange change2(StateChange::StateCallFunction, SC_WriteZclAttribute, task.req.dstEndpoint());

For classic device the normal command is

StateChange change(StateChange::StateWaitSync, SC_WriteZclAttribute, task.req.dstEndpoint());

But don't work for tuya stuff. Can make a test using fingerprint and add it in DDF.

Smanar avatar May 17 '22 20:05 Smanar

Is there anything that keeps this PR from being merged at the moment that I can help with?

TheHaf avatar Jun 30 '22 10:06 TheHaf

@Smanar can I do anything here? Test with Tuya devices for example?

EmJay276 avatar Jul 10 '22 19:07 EmJay276

IDK, the PR can actually work, it probably don't respect deconz rules, but I need to know what is not good, to correct them.

But I have a good new, Mimix have mentionned there is too much PR in waiting list, so I think someone will take in care all of them, and close/answer/validate them, so I hope for a return for this one.

Smanar avatar Jul 11 '22 15:07 Smanar

@manup this one is blocking a lot of device supports.

Mimiix avatar Aug 30 '22 21:08 Mimiix

Winter season is coming fast. Would be great to get the tuya devices finally into deconz.

containerguy avatar Sep 21 '22 18:09 containerguy

Ok so the code was updated here https://github.com/dresden-elektronik/deconz-rest-plugin/commit/f17ab0097bf01d613b2303d380fcd68d1d0735e4#diff-7548d412985c02a5cf5b188c22b61937c468e2ce2914e8ee4e8c13cd28e0750b

So I can remove the hack

Added the Tuya TRV _TZE200_thbr5z34 to test code.

@SwoopX Do you think this can cause problem ? https://github.com/dresden-elektronik/deconz-rest-plugin/pull/6054/files#diff-7548d412985c02a5cf5b188c22b61937c468e2ce2914e8ee4e8c13cd28e0750bL1692 It's for RConfigLocked.

Smanar avatar Jan 14 '23 13:01 Smanar

@Smanar I'm afraid the whole PR has some good potential to break stuff ans as I see it, there might also be merge conflicts. Wondering who this is not reported...

Anyway, there's so much unnecessary and outdated stuff in it, I'd rather recommend to close this one down and come up with a fresh and clean new one.

SwoopX avatar Jan 14 '23 23:01 SwoopX

Nothing repoeted perhaps because it was updated with last master.

New Clean version here https://github.com/dresden-elektronik/deconz-rest-plugin/pull/6674 I close this one, is someone can try the new one ?

Smanar avatar Jan 15 '23 09:01 Smanar

I know the winter saison is close to finish, but if someone with a Tuya TRV can test the new code https://github.com/dresden-elektronik/deconz-rest-plugin/pull/6674 ? I can (try to) make a DDF for unsupported TRV if needed.

Smanar avatar Jan 16 '23 09:01 Smanar

Locking this one, please proceed in #6674

Mimiix avatar Jan 16 '23 10:01 Mimiix