deconz-rest-plugin icon indicating copy to clipboard operation
deconz-rest-plugin copied to clipboard

Adding Sinope Thermostat TH11xxZB management of Occupancy specific attribute and Unoccupied heat set point

Open BabaIsYou opened this issue 3 years ago • 11 comments

Adding management via REST-API of specific Occupancy Sinope state attribut and Unoccupied heat set point. Taht way thermostat can switch automatically to unoccupied heating set point or occupied heating set point depending on the value of Occupancy.

BabaIsYou avatar May 03 '22 20:05 BabaIsYou

@manup There is a problem with this PR ? And here there is just some xml addition https://github.com/dresden-elektronik/deconz-rest-plugin/pull/5968

Smanar avatar Jun 03 '22 15:06 Smanar

I think it should be fine, but like to have more opinions on that before adding new resource items. We need to care to being more streamlined than in the past.

manup avatar Jun 04 '22 11:06 manup

The fact that you find it useless doesn't necessarily make it pointless. On the contrary, I think it's brilliant of the manufacturer to have provided this possibility. ;-)

So I can assign a different value of unoccupied setpoint for each room and just change the value of local_unoccupancy so that the thermostat takes automatically the heating value of unoccupiedsetpoint instead of having to change the heatsetpoint for each thermostat from my home automation system.

Programsmation and management of thermostats by script become simpler from my automation system.

As occupancy is readonly in Zigbee specification it seems that the manufacturer had to add another writable attribute.

That beeing said, if the only trouble is to change some attributes names to avoid confusion or to be compliant to some rules to have this PR accepted just tell me waht the name you prefer instead of local_occupancy (local refers to room).

Thanks

BabaIsYou avatar Jun 06 '22 10:06 BabaIsYou

@SwoopX To be consistent with other config items (externalsensortemp and externalwindowsopen), what would you think about externaloccupancy or externalsensoroccupancy ?

BabaIsYou avatar Jun 15 '22 17:06 BabaIsYou

I schedule this for the next beta after stable, so we need to work out a opinion and naming for these items :)

manup avatar Jun 30 '22 13:06 manup

Also, sometimes DDF file for Sinope are not loaded because of legacy code is overwriting the real value reported by the manufacturer name attribute. Then we have to force reading of basic cluster as @SwoopX described it in support forum issue 2121

BabaIsYou avatar Jul 20 '22 13:07 BabaIsYou

For me, we can remove this part in code

    else if ((node->nodeDescriptor().manufacturerCode() == VENDOR_SINOPE))
    {
        sensorNode.setManufacturer("Sinope");
    }
  • try to modify the model id or the manufacture name is the worst idea possible
  • I don't think it can have an impact on previous integrated device.

Smanar avatar Jul 20 '22 15:07 Smanar

Do we have any new considerations for the local_occupancy / occupancy naming? I have to admit the thermostat topic is still a bit of a black box for me with all the variations floating around.

One note to the item description generic/items/config_local_occupancy_item.json: I think as a generic item which can be device specific the read, write and parse functions should be specified in the device DDF. For example here the 0x0400 attribute appears to be vendor specific.

manup avatar Aug 28 '22 11:08 manup

I totaly agree that the binding/location in cluster that are device/manufacturer specific are to be preferably located in devices DDF. But, as I remember, that does not make it writable until you bind it to a already existing writable item. At time we discussed it with @smanar there wasn’t such an existing config item with a name and a corresponding data type.

Le 28 août 2022 à 07:40, Manuel Pietschmann @.***> a écrit :



Do we have any new considerations for the local_occupancy / occupancy naming? I have to admit the thermostat topic is still a bit of a black box for me with all the variations floating around.

One note to the item description generic/items/config_local_occupancy_item.json: I think as a generic item which can be device specific the read, write and parse functions should be specified in the device DDF. For example here the 0x0400 attribute appears to be vendor specific.

— Reply to this email directly, view it on GitHubhttps://github.com/dresden-elektronik/deconz-rest-plugin/pull/6011#issuecomment-1229439160, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUKZIKIJJ3AFMJHI4N6TQVLV3NF2FANCNFSM5U75TFDQ. You are receiving this because you authored the thread.Message ID: @.***>

BabaIsYou avatar Aug 28 '22 11:08 BabaIsYou

I think as a generic item which can be device specific the read, write and parse functions should be specified in the device DDF

I m not sure to understand, there is something missing ? You mean to use it in the device DDF and not the generic folder ?

Smanar avatar Aug 28 '22 15:08 Smanar

Related thermostat items streamline issue: https://github.com/dresden-elektronik/deconz-rest-plugin-v2/issues/13

manup avatar Sep 05 '22 16:09 manup

I schedule this for the next beta after stable, so we need to work out a opinion and naming for these items :)

Seems we skipped some milestones ... Chance to have it in next one ?

BabaIsYou avatar Oct 04 '22 01:10 BabaIsYou