Addition of Sinope SP2600ZB, SP2610ZB, RM3250ZB Smart Plugs, Smart Controller

[joelwener]

added the devices to be recognized, data properly converted.

[joelwener]

These changes complete device addition requests: #4880 #4871 #4870, and adds on Pull request #4889

[joelwener]

Hi,

I didn't include instantaneous power demand, as it is not included in the devices. I did included the kWh consumption (current Summation) which includes the ZhAConsumption sensor. Not sure why you are indicating to exclude it.

All devices as far as I am concerned are included completely, I don't believe I have left anything out.

I will fix the spacing in bindings.cpp

On Sat., May 29, 2021, 6:11 p.m. SwoopX, @.***> wrote:

@SwoopX requested changes on this pull request.

Thanks for raising this PR. We appreciate that you are eager to get the devices supported, but for the SP2610ZB, this will end up in a bit of a mess due to the Salami tactics. As this and the other associated PR do contain common and individual changes, this will most likely result in duplicate entries and merge conflicts. In that sense, please either fully include the device with all the required changes or spare it out.

As for the content related changes, it looks already pretty good. Please correct indentation throughout the amendments of bindings.cpp (it's spaces, not tabs). What's then still missing is the explicit exclusion of all 3 devices in the 2 files mentioned here #4889 (review) https://github.com/dresden-elektronik/deconz-rest-plugin/pull/4889#pullrequestreview-664786246 so they do not get an unnecessary power resource item in the ZHAConsumption sensor.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dresden-elektronik/deconz-rest-plugin/pull/4943#pullrequestreview-671776533, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUBXQCQDDDWVXTPADT6J33DTQFRCZANCNFSM45YHRQOA .

[manup]

I can't tell wherever the RStatePower item needs to be excluded @SwoopX what's your view here? I remember we had devices which reported bogus values for some attributes, is this the reason?

[manup]

By default, RStateConsumption and RStatePower get created for ZHAConsumption sensors and none of the 3 devices supports power there. I can already anticipate the future issues that power is always 0 (we had some for other devices), so I'll stick to my previous comment. This is, I'm afraid, no matter of believe wink

Perhaps, we should consider changing the defaults for ZHAConsumption and only add the items explicitly when the device actually supports them.

[SwoopX]

Yeah, I would appreciate that although I haven't dared yet since I don't know if our supported devices documentation is good enough for that 🤔

[BabaIsYou]

Perhaps adding DDF file like in PR #5962 will permit to release this PR until final state on this useless reported power ?