Multi-row functionality
Still a work in progress, but here's some screenshots:
Remaining tasks
- [x] Swap to large icon when the row count is greater than 1 (see Vista)
- [x] Fix unlocked mode glitches (especially prominent in XP Blue based styles)
- [x] Remove rounded corners when unlocked (side effect of ResizingMode="CanResize").
- [x] Keep row count in settings
- [ ] Adjust style properties to explicitly handle row heights instead of assuming each row doubles the taskbar height
- [x] Allow resizing on sides and top
(Many were hot-fixed by replacing drag functionality with a settings option)
Here's every taskbar with 2 rows:
System
System XP
Watercolor
Windows 2000
Windows 95-98
Windows Longhorn Aero
Windows Me
Windows Vista Aero
Windows Vista Basic
Windows Vista Classic
Windows XP Blue
Windows XP Classic
Windows XP Embedded
Windows XP Olive Green
Windows XP Royale Noir
Windows XP Royale
Windows XP Silver
Windows XP Zune
Small update. The toolbar is now vertically centered (on every taskbar)
Hey, thanks, this is looking great so far! I am going to try to take a deeper look at this soon.
Alignment changes made
I added the expanded clock, and it works great for System XP and Vista, but the padding is a bit messed up (especially on XP Blue)
I added the vertical orientation adjustment:
Based on this I have two proposals
- [ ] Add padding
- [ ] Flip the FlowDirection (and item order?)
Very nice work. I have tested this version for a week now and it is very good.
1 thing that is missing is multirow functionality for the quicklaunch items, would that be possible to add? @Avid29 now the quicklaunch items are all in 1 row,
screenshot:
EDIT: as a suqqestion, divide the amount of quicklaunch icons by the row amount: 2 rows 10 icons would then be 5 icons on each row, 3 rows and 12 icons would be 4 icons on each row... and so on.
@MKKNinetyTwo Done. Pushing now
@MKKNinetyTwo Done. Pushing now
This is perfect. Thanks!
screenshot:
Add padding
The padding and alignment of the tray icons will need some changes in a few themes. There are a few other sizing changes that will need to be made anyway. I'm okay making those minor changes later.
Flip the FlowDirection (and item order?)
I tested this and don't think it will do what we want, what are you looking to affect with this change?
Flip the FlowDirection (and item order?)
I tested this and don't think it will do what we want, what are you looking to affect with this change?
I haven't tested it yet, but I expect that if the number of items in the NotifyIconsList is not divisible by the number of rows the system clock side will have empty slots were items would be while the expected behavior is that they would fill in from that side. You'd also still expect the system icons (volume, network, and such) to be on the system clock side.
If someone wants these I made Finnish translation, and 2 custom Windows 7 themes.
These were made for Avid29 RetroBar_resizable_taskbar, but should work on original RetroBar too. Can be added to retrobar github if you want @dremin
Windows 7 Royale Noir (Vista theme base, Xp Royale Noir colors, Win7 startmenu):
Windows 7 Zune (Vista theme base, Xp Zune colors, Win7 startmenu):
Translation and themes: EDIT: Finnish translation download removed, see Pull Request instead https://github.com/Avid29/RetroBar/pull/1 https://www.mediafire.com/file/zkvruzec1ujrxqq/RetroBar_Windows_7_Custom_Themes.rar
@MKKNinetyTwo You can submit a translation through a separate pull request :)
@MKKNinetyTwo You can submit a translation through a separate pull request :)
I know, but the translation has lines for "row count" etc that Avid29 added, which are not yet on the main repo, Some strings are only on Avid29 repo at the moment. So I need to wait until this pull request is accepted, or if Avid29 wants to add the translation to his own repo, it is fine too.
Flip the FlowDirection (and item order?)
I tested this and don't think it will do what we want, what are you looking to affect with this change?
I haven't tested it yet, but I expect that if the number of items in the NotifyIconsList is not divisible by the number of rows the system clock side will have empty slots were items would be while the expected behavior is that they would fill in from that side. You'd also still expect the system icons (volume, network, and such) to be on the system clock side.
Our behavior seems to match Windows XP already--the empty slots are on the clock side on both.
Flip the FlowDirection (and item order?)
I tested this and don't think it will do what we want, what are you looking to affect with this change?
I haven't tested it yet, but I expect that if the number of items in the NotifyIconsList is not divisible by the number of rows the system clock side will have empty slots were items would be while the expected behavior is that they would fill in from that side. You'd also still expect the system icons (volume, network, and such) to be on the system clock side.
Our behavior seems to match Windows XP already--the empty slots are on the clock side on both.
Oh, never mind then
Flip the FlowDirection (and item order?)
I tested this and don't think it will do what we want, what are you looking to affect with this change?
I haven't tested it yet, but I expect that if the number of items in the NotifyIconsList is not divisible by the number of rows the system clock side will have empty slots were items would be while the expected behavior is that they would fill in from that side. You'd also still expect the system icons (volume, network, and such) to be on the system clock side.
Our behavior seems to match Windows XP already--the empty slots are on the clock side on both.
"...You'd also still expect the system icons (volume, network, and such) to be on the system clock side..."
empty blocks, volume and network are on the clock side, but "removable devices" is not on clock side on retrobar. I dont know how the "removable devices" is on win xp.
Once the requested changes are made, I have a follow up patch to enable drag resizing:
https://github.com/user-attachments/assets/af11d34b-2073-484d-9692-57fb2f4b5551
Once the requested changes are made,
so the remaining changes are: vertical_alignment, rowcount_text, and label target of combo_box?
btw, I noticed that the volume icon is not changing from muted to not-muted icon when clicked, I am not sure if it is retrobar bug or if it is happening only on the multirow version (running on windows 11).
I pushed a slew of changes to this branch which adds the drag resize, as well as a bunch of minor theme improvements for multi-row. I believe this is at a point it can be merged, but would appreciate others testing :)
I pushed a slew of changes to this branch which adds the drag resize, as well as a bunch of minor theme improvements for multi-row. I believe this is at a point it can be merged, but would appreciate others testing :)
Very nice.
I made a PR for the Finnish translation if you want to add it: https://github.com/Avid29/RetroBar/pull/1
@dremin Alright, I believe this should be ready!
