Damien Regad
Damien Regad
Hello @grummbeer, I'm sorry for the delayed response, I have been quite busy in the past few weeks... I finally found some time to look at this again today. >...
> The current state of the CSS scares me. :-) Yeah. The Ace template legacy is horrible. And preventing us from upgrading to more recent version of Bootstrap, too... But...
This looks much better than the code you initially proposed in https://github.com/mantisbt/mantisbt/pull/1992#issuecomment-2062124253, where I didn't like the approach of BEGIN/END events to add HTML. At first glance, this seems much...
> Also fixes the error message when an invalid version is provided ([#34410](https://mantisbt.org/bugs/view.php?id=34410)). I have merged this minor fix in 2.26 branch (see 4859fc1fbcf7547e057cc4520a880a2b56231b55), without waiting for this PR's review
Without feedback following my note https://mantisbt.org/bugs/view.php?id=25407#c68929, I'm going to merge this sometime this week.
Thanks for your contribution. I'll review when I have some time, and get back to you.
@vboctor just making sure you're aware, that this is not about URL links (what you seem to be referring to), but links to attachments. For context, please read https://mantisbt.org/forums/viewtopic.php?f=2&t=25561
Merged in d1cc59114e6ff3498d1f874557b8a667e19b86c7 Thanks @lucmuller @MaloMn for your contribution !
Sorry I've been busy. Haven't had time to review changes submitted since my last review yet, will do as time allows, but just wanted to give you feedback on your...
> I can use changelog_include_issue but only server-side (in Javascript I need to check resolution value agains the two threshold manually), I would prefer have same checks without using changelog_include_issue...