Damien Regad

Results 262 comments of Damien Regad

Suggested enhancement: instead of using a hardcoded, generic _Plugins_ string and _fa-plug_ icon, I believe it would be better to let the plugin set the main menu item's entry as...

> Is that the intended usage for this feature? I just implemented a quick&dirty test setup to review the PR, and do not necessarily endorse such use. My main point...

@JeremyOWO > I'mnot understanding situation. It's quite simple, really : This PR is currently in no condition to be merged. It contains errors (see review comments) and just does not...

@syncguru removing the `` does not fix the problem at all. I think it's a problem in the ACE CSS (or the way we use it), because if you set...

> we are not using it correctly So what would be the correct way to use it, then ? > Happy to email you a copy If you could, that...

I would appreciate if you guys could actually perform some testing on this, to ensure I did not break anything related to authentication or introduce any security issues.

Thanks for the advice. No I didn't - focused mainly on behavior in "normal" usage scenarios (as anonymous with/without login and as a registered user, switching back and forth between...

@badfiles as far as I can tell, setting the cookies fixes the issue... (the existence of the cookies is essentially the only difference between a direct page browsing vs the...

@badfiles thanks for testing, but I'm afraid your report is not really clear... Is this patch fixing your problem or not ? Could the fact that you did not see...

@vboctor @cproensa any objections to me merging this ?