Damien Regad

Results 262 comments of Damien Regad

@vboctor @brlumen what is the status of this PR ?

Hmmm looks like I broke pgsql builds somehow :disappointed:

From Travis log: ``` Schema step 51: InsertData ( mantis_user_table ) BAD INSERT INTO mantis_user_table( username, realname, email, password, date_created, last_visit, enabled, protected, access_level, login_count, lost_password_request_count, failed_login_count, cookie_string ) VALUES...

> Looks like the pull request description is truncated at the end. Not sure what happened. Fixed now. > We should capture the schema guidelines for future tables, indices, default...

There's one thing that bothers me with this, and I'm not really sure how to properly handle it. Creating the schema (schema.php/install.php) and checking it (admin checks) is one thing,...

I decided to change this PR's scope, as described in the revised opening text. The purpose is to avoid delaying bugfixes for the master branch, as well as the code...

In reply to @atrol's latest comment > Consider also that database setting can be utf8mb4 but the table is utf8. I did actually, and this is one of the reasons...

> consider using GuzzleHttp for checking if the admin folder is accessible I was actually considering that as an alternative, since a friend told me that using file_get_contents was not...

> the admin/ path not being accessible doesn't mean all scripts on the admin folder is not accessible (that would depend on htaccess rules) That's true (although it would be...

> Guzzle requires PHP >= 5.5 whereas we still have set define( 'PHP_MIN_VERSION', '5.3.2' ); This is actually no longer the case since 2.7.0 (PR #1187 commit 380fde11d50c22ef94210822d60b5f576c9d4a34) Any objections...