Pine64-Arch icon indicating copy to clipboard operation
Pine64-Arch copied to clipboard

sxmo/sxmo-utils: Update and add fixes

Open 3nprob opened this issue 2 years ago • 3 comments

  • Add upstream changes
  • Add git as makedepends
  • Fix symlink destination for appscripts (without this, building in chroot results in incorrect locations in resulting fs)
  • Fix pinephone pro charging status (without this, script will error trying to read non-existing paths for rk818)

3nprob avatar Feb 27 '22 10:02 3nprob

This looks useful, but I don't Danctnix is the correct place for it. It would be much better in the aur as a sxmo-utils-git package, although there might be issues with packages that are only in Danctnix, I'd be happy to work on getting those into the aur.

Also the patches you're including don't look like they do anything arch specific, so they should be sent to the sxmo-devel mailing list, rather than applying them here.

Beyond that if you want to see these patches in danctnix you'll need to wait for sxmo to make a release. My aim is to ship the release version of sxmo, and only apply patches for Arch specific things when they can't be upstreamed, or aren't in time.

ArenM avatar Feb 28 '22 00:02 ArenM

@ArenM: Makes sense (intentions and scope aren't super clear so responses like this and the associated maintainer reaction are helpful to make the rest of us understand what's going on ^^)

It guess that this could be considered Arch-specific and broken out in a separate PR?

https://github.com/dreemurrs-embedded/Pine64-Arch/pull/335/files#diff-f8c0c0cc3a5bf3d7477a718b3c78fb879a5c1a7ac2cc151c5d93f2ac165ba448

3nprob avatar Feb 28 '22 08:02 3nprob

I don't think that patch is actually arch specific, the commit that added that originally hasn't made it into a release yet, so I'm guessing no one has tried to build sxmo-utils with a DESTDIR set. It would be good if you sent that patch upstream to at least get more sets of eyes on it.

ArenM avatar Feb 28 '22 18:02 ArenM

Closing due to it being stale.

Danct12 avatar Sep 05 '22 02:09 Danct12