rehlds icon indicating copy to clipboard operation
rehlds copied to clipboard

TESTING: fix crash due to SZ_GetSpace console overflow

Open RauliTop opened this issue 2 years ago • 9 comments

More info here: https://github.com/dreamstalker/rehlds/issues/855

Also, review this: https://github.com/dreamstalker/rehlds/issues/798

RauliTop avatar Apr 08 '22 19:04 RauliTop

help version Protocol version 48 Exe version 1.1.2.7/Stdio (cstrike) ReHLDS version: 3.11.0.776-devmpatch Build date: 18:17:32 Apr 26 2022 (2936) Build from: https://github.com/dreamstalker/rehlds/commit/3dc9f8c SZ_GetSpace: overflow on gs-m <- russian WARNING: datagram overflowed for gs-m <- russian

Kasou123 avatar May 04 '22 14:05 Kasou123

Is there any solution to this problem with this message, and how is the problem fixed?

overflow on netchan->message

stambeto2006 avatar May 22 '22 09:05 stambeto2006

@RauliTop Is this project expected to be implemented and fixed officially soon?

stambeto2006 avatar Jul 10 '22 12:07 stambeto2006

@RauliTop Is this project expected to be implemented and fixed officially soon?

I really didn't test it. I'm currently doing changes on plugins, without successful results.

You can try my request downloading the binaries on Actions tab inside this repository. Pull request has been updated now with lastest rehlds official changes.

RauliTop avatar Jul 11 '22 17:07 RauliTop

More info here: #855

Also, review this: #798

my servers go down with that same message I discovered that it is an attacker even then I enter the servers to ask for money in exchange so as not to continue attacking I have everything updated rehlds, amx, etc and even so your proposal can solve this too? I attach some videos of how he does it

https://www.youtube.com/watch?v=tCQ0tFdUTho

https://www.youtube.com/watch?v=Ex4n9KfUiCQ

https://www.youtube.com/watch?v=WMDZvrewaNI

Alguiencomoyo avatar Sep 22 '22 07:09 Alguiencomoyo

also affects? rehlds/engine/cmd.cpp#L122

mlibre2 avatar Jul 15 '23 03:07 mlibre2

also affects? rehlds/engine/cmd.cpp#L122

No, because after overflow it appears: 'on' %s It's on the line I marked.

RauliTop avatar Jul 16 '23 15:07 RauliTop

Well this problem is quite common, apparently one of the causes is the loss of the player's connection to the server. sv_timeout is a quick fix for this, but I wanted to find another one, since this cvar doesn't work quite right, so I wrote this plugin to check the communication with the player. This method has worked well for me so far, although I don't like to call a function frequently, maybe there is another more optimal way to do it, but at least it doesn't print the typical "overflow/datagram" error message to the console, which that prevents it from happening.

So far it has been ruled out that the false positives have been kicked without reason!

mlibre2 avatar Jul 16 '23 23:07 mlibre2

This is wrong, it does not match original code.

There is no Con_NetPrintf in SZ_GetSpace in original HLDS. If this is a ReHLDS fix, it should be wrapped in #ifdef REHLDS_FIXES appropriately.

Also I don't think Con_Printf has anything to do with the error.

anzz1 avatar Jan 19 '24 08:01 anzz1