tabnet
tabnet copied to clipboard
Added hyperparameter tuning example notebook
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
What kind of change does this PR introduce? Added am example notebook with Hyperparameter tuning for TabNet with early stopping. I was looking for an example implementation for a long time and then I found it in one of your closed issues #80 . Perhaps having it as a separate notebook would be useful for a lot of folks. Kudos to @Hartorn for the answer!
Does this PR introduce a breaking change? No
What needs to be documented once your changes are merged? Nothing
Closing issues
closes #80
Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).
Thanks for your PR @plamenpasliev.
The CI is broken for building the gpu so we'll need to fix this before hand.
I did not have a close look at your notebook but in order to add it to the repo you'll need to add it to the ci so that it we can check that things would work well with the next changes. To do so you must add a test here : .circleci/config.yml (simply copy past one existing test and change the path/namings accordingly)
Thanks for your PR @plamenpasliev.
The CI is broken for building the gpu so we'll need to fix this before hand.
I did not have a close look at your notebook but in order to add it to the repo you'll need to add it to the ci so that it we can check that things would work well with the next changes. To do so you must add a test here :
.circleci/config.yml(simply copy past one existing test and change the path/namings accordingly)
Thanks for the reply @Optimox !
I changed the Makefile and config but the issue still persists. It also seems that everybody has this issue here: https://app.circleci.com/pipelines/github/dreamquark-ai/tabnet
Do you know what might be the cause of this?
+ mktemp -d
+ export GNUPGHOME=/tmp/tmp.Q82R4gTJpB
+ echo disable-ipv6
+ gpg --batch --keyserver ha.pool.sks-keyservers.net --recv-keys 0D96DF4D4110E5C43FBFB17F2D347EA6AA65421D
gpg: keybox '/tmp/tmp.Q82R4gTJpB/pubring.kbx' created
gpg: keyserver receive failed: No name
Yes don't worry about the error regarding the gpu-docker-build, I'll fix it and you'll just have to rebase on develop. The test for your notebook seem to fail as well, only focus on that. Also, in the end, you'll need to squash all your commit into only one (but maybe you can save this for the end)