Patryk Obara

Results 164 comments of Patryk Obara
trafficstars

This feature is needed to fully support typing (not sure about properly displaying) characters, e.g.: by default, DOSBox **won't take input** when I'll try to type in: ąęłźżó. To make...

Yeah, bundling more codepages (e.g. all the ones that FreeDOS provides) with the DOSBox might be a better way of addressing this than including KC or changing code. And I...

Comment in this DOSBox code: ``` /* This file contains data of .KL-files. They have been generated by Henrique Peron using FreeDOS KC and are combined into .SYS files. */...

Just did a brief testing on Linux, and debugger feature seems to be generally broken - UI randomly disappears, sometimes appear again. Perhaps debugger feature is not compatible with logs...

For the people who might not know `NDEBUG` is the standard C mechanism for disabling `assert` statements in code. We use it also for prevent printing additional logs, that are...

@SupervisedThinking these patches predate SDL2 and OpenGL glshader support, so they won't apply to our code :( When we started work on importing SDL2 patch, it had OpenGLES bits for...

Using `std::string`, `string_view`, `regex`, etc is completely fine - especially in new functions, classes, interfaces. But please avoid aggressive refactors. Light refactors are fine IMHO. We already had some aggressive...

Definitely; several DOSBox forks exist dedicated *only* to bringing in nice shaders, so this is definitely a desired feature - it would also allow us to remove ugly rgb* and...

OK, upstream shader support got just merged into the master branch, but it does not affect this issue - we still want to support GLSL shaders and shader presets in...

At this point these messages are only written to log / stdout. Option to display them in GUI overlay would quite cool and very welcome considering this is part of...