univer
univer copied to clipboard
fix(sheet): save edit content when select other tab
close #xxx, #yyy, #zzzz
Codecov Report
Attention: Patch coverage is 91.98113%
with 17 lines
in your changes are missing coverage. Please review.
Project coverage is 30.75%. Comparing base (
0ed9f56
) to head (18ec824
).
Additional details and impacted files
@@ Coverage Diff @@
## dev #2160 +/- ##
==========================================
+ Coverage 30.65% 30.75% +0.10%
==========================================
Files 1272 1272
Lines 70149 70172 +23
Branches 14863 14801 -62
==========================================
+ Hits 21504 21582 +78
+ Misses 48645 48590 -55
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Bot detected the issue body's language is not English, translate it automatically. ๐ฏ๐ญ๐ป๐งโ๐คโ๐ง๐ซ๐ง๐ฟโ๐คโ๐ง๐ป๐ฉ๐พโ๐คโ๐จ๐ฟ๐ฌ๐ฟ
Origin Title: fix(sheet): save edit content when select other tab
Title: fix(sheet): save edit content when select other tab
- [x] Fixed the problem of switching to other worksheets when selecting a formula range and saving data to other worksheets. How to test?
- Create two new blank worksheets: Worksheet 1, Worksheet 2
- Edit
=
in cell A1 of Sheet 1, switch to Sheet 2 and select the B1 range - Enter to confirm. At this time, it automatically switches back to worksheet 1, and the content of A1 is updated to
=worksheet 2!B1
(previously, the data was saved to worksheet 2, [Univer Preview](https://univer-preview .vercel.app/sheets/))
- [x] Completed all formula parameter number error prompts How to test? For example, when testing OFFSET, if there are less than 3 or more than 5 parameters, a #N/A error will be reported. The same applies to other formulas (other types of errors are not included for now)
้ฎ้ข1ใ
maxๅฝๆฐๅผ็จ้ๆฐๅญๅค็ๅผ๏ผ่ฎก็ฎ็ปๆไธบ็ฉบ
excelๅgoogleๆพ็คบไธบ0
้ฎ้ข2ใ
MODๅฝๆฐ่ขซ้คๆฐ่ฟ้ฟๆถ็ปๆ่ฎก็ฎไธบ0๏ผๆชๆฅ้
excel๏ผๆฅ้
google๏ผๆฅ้
Bot detected the issue body's language is not English, translate it automatically. ๐ฏ๐ญ๐ป๐งโ๐คโ๐ง๐ซ๐ง๐ฟโ๐คโ๐ง๐ป๐ฉ๐พโ๐คโ๐จ๐ฟ๐ฌ๐ฟ
Question 1,
The max function refers to a value other than a number, and the calculation result is empty.
excel and google display as 0
Question 2.
When the dividend of the MOD function is too long, the result is calculated as 0 and no error is reported.
excel: error
google: error report
@Dushusir ็ผ่พๆถๅๆข่กจๆ ผ๏ผ็ผ่พๅ ๅฎนๆฒกๆๅ ไฟๅญ
Bot detected the issue body's language is not English, translate it automatically. ๐ฏ๐ญ๐ป๐งโ๐คโ๐ง๐ซ๐ง๐ฟโ๐คโ๐ง๐ป๐ฉ๐พโ๐คโ๐จ๐ฟ๐ฌ๐ฟ
@Dushusir When switching tables during editing, the edited content is not saved first