univer icon indicating copy to clipboard operation
univer copied to clipboard

fix(sheet): save edit content when select other tab

Open Dushusir opened this issue 9 months ago โ€ข 2 comments

close #xxx, #yyy, #zzzz

Dushusir avatar May 06 '24 07:05 Dushusir

Codecov Report

Attention: Patch coverage is 91.98113% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 30.75%. Comparing base (0ed9f56) to head (18ec824).

Files Patch % Lines
packages/sheets-formula/src/services/utils.ts 0.00% 9 Missing :warning:
...es/engine-formula/src/functions/meta/cube/index.ts 0.00% 3 Missing :warning:
...engine-formula/src/functions/meta/compare/index.ts 0.00% 2 Missing :warning:
...engine-formula/src/functions/meta/divided/index.ts 0.00% 2 Missing :warning:
...s-ui/src/controllers/editor/end-edit.controller.ts 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2160      +/-   ##
==========================================
+ Coverage   30.65%   30.75%   +0.10%     
==========================================
  Files        1272     1272              
  Lines       70149    70172      +23     
  Branches    14863    14801      -62     
==========================================
+ Hits        21504    21582      +78     
+ Misses      48645    48590      -55     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 06 '24 07:05 codecov[bot]

View Deployment

๐Ÿ“‘ Examples ๐Ÿ“š Storybook
๐Ÿ”— Preview link ๐Ÿ”— Preview link

github-actions[bot] avatar May 06 '24 07:05 github-actions[bot]

Bot detected the issue body's language is not English, translate it automatically. ๐Ÿ‘ฏ๐Ÿ‘ญ๐Ÿป๐Ÿง‘โ€๐Ÿคโ€๐Ÿง‘๐Ÿ‘ซ๐Ÿง‘๐Ÿฟโ€๐Ÿคโ€๐Ÿง‘๐Ÿป๐Ÿ‘ฉ๐Ÿพโ€๐Ÿคโ€๐Ÿ‘จ๐Ÿฟ๐Ÿ‘ฌ๐Ÿฟ

Origin Title: fix(sheet): save edit content when select other tab

Title: fix(sheet): save edit content when select other tab


  • [x] Fixed the problem of switching to other worksheets when selecting a formula range and saving data to other worksheets. How to test?
  1. Create two new blank worksheets: Worksheet 1, Worksheet 2
  2. Edit = in cell A1 of Sheet 1, switch to Sheet 2 and select the B1 range
  3. Enter to confirm. At this time, it automatically switches back to worksheet 1, and the content of A1 is updated to =worksheet 2!B1 (previously, the data was saved to worksheet 2, [Univer Preview](https://univer-preview .vercel.app/sheets/))
  • [x] Completed all formula parameter number error prompts How to test? For example, when testing OFFSET, if there are less than 3 or more than 5 parameters, a #N/A error will be reported. The same applies to other formulas (other types of errors are not included for now)

univer-bot[bot] avatar May 08 '24 03:05 univer-bot[bot]

้—ฎ้ข˜1ใ€ maxๅ‡ฝๆ•ฐๅผ•็”จ้žๆ•ฐๅญ—ๅค–็š„ๅ€ผ๏ผŒ่ฎก็ฎ—็ป“ๆžœไธบ็ฉบ image

excelๅŠgoogleๆ˜พ็คบไธบ0 image

้—ฎ้ข˜2ใ€ MODๅ‡ฝๆ•ฐ่ขซ้™คๆ•ฐ่ฟ‡้•ฟๆ—ถ็ป“ๆžœ่ฎก็ฎ—ไธบ0๏ผŒๆœชๆŠฅ้”™ image

excel๏ผšๆŠฅ้”™ image google๏ผšๆŠฅ้”™ image

oumomomo avatar May 08 '24 11:05 oumomomo

Bot detected the issue body's language is not English, translate it automatically. ๐Ÿ‘ฏ๐Ÿ‘ญ๐Ÿป๐Ÿง‘โ€๐Ÿคโ€๐Ÿง‘๐Ÿ‘ซ๐Ÿง‘๐Ÿฟโ€๐Ÿคโ€๐Ÿง‘๐Ÿป๐Ÿ‘ฉ๐Ÿพโ€๐Ÿคโ€๐Ÿ‘จ๐Ÿฟ๐Ÿ‘ฌ๐Ÿฟ

Question 1, The max function refers to a value other than a number, and the calculation result is empty. image

excel and google display as 0 image

Question 2. When the dividend of the MOD function is too long, the result is calculated as 0 and no error is reported. image

excel: error image google: error report image

univer-bot[bot] avatar May 08 '24 11:05 univer-bot[bot]

@Dushusir ็ผ–่พ‘ๆ—ถๅˆ‡ๆข่กจๆ ผ๏ผŒ็ผ–่พ‘ๅ†…ๅฎนๆฒกๆœ‰ๅ…ˆไฟๅญ˜

zhaolixin7 avatar May 08 '24 12:05 zhaolixin7

Bot detected the issue body's language is not English, translate it automatically. ๐Ÿ‘ฏ๐Ÿ‘ญ๐Ÿป๐Ÿง‘โ€๐Ÿคโ€๐Ÿง‘๐Ÿ‘ซ๐Ÿง‘๐Ÿฟโ€๐Ÿคโ€๐Ÿง‘๐Ÿป๐Ÿ‘ฉ๐Ÿพโ€๐Ÿคโ€๐Ÿ‘จ๐Ÿฟ๐Ÿ‘ฌ๐Ÿฟ

@Dushusir When switching tables during editing, the edited content is not saved first

univer-bot[bot] avatar May 08 '24 12:05 univer-bot[bot]