univer icon indicating copy to clipboard operation
univer copied to clipboard

fix(editor): add valid attribute

Open DR-Univer opened this issue 11 months ago β€’ 4 comments

close #xxx, #yyy, #zzzz

DR-Univer avatar Mar 28 '24 15:03 DR-Univer

View Deployment

πŸ“‘ Examples πŸ“š Storybook
πŸ”— Preview link πŸ”— Preview link

github-actions[bot] avatar Mar 28 '24 15:03 github-actions[bot]

@Gggpound θŒƒε›΄ι€‰ζ‹©ε™¨δΈζ„ŸηŸ₯ε…·δ½“θ‘¨ζ ΌοΌŒιœ€θ¦δ½ εœ¨ε€–ιƒ¨εˆ€ζ–­οΌŒη„ΆεŽδΌ ε‚εˆ°rangeSelector内部。

DR-Univer avatar Mar 28 '24 15:03 DR-Univer

Bot detected the issue body's language is not English, translate it automatically. πŸ‘―πŸ‘­πŸ»πŸ§‘β€πŸ€β€πŸ§‘πŸ‘«πŸ§‘πŸΏβ€πŸ€β€πŸ§‘πŸ»πŸ‘©πŸΎβ€πŸ€β€πŸ‘¨πŸΏπŸ‘¬πŸΏ

@Gggpound The range selector is not aware of the specific table. You need to judge externally and then pass the parameters to the rangeSelector internally.

univer-bot[bot] avatar Mar 28 '24 15:03 univer-bot[bot]

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 30.44%. Comparing base (893b810) to head (d90f687). Report is 110 commits behind head on dev.

Files Patch % Lines
packages/ui/src/components/editor/TextEditor.tsx 0.00% 5 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1730      +/-   ##
==========================================
- Coverage   31.78%   30.44%   -1.34%     
==========================================
  Files        1041     1213     +172     
  Lines       57853    74660   +16807     
  Branches    12165    17161    +4996     
==========================================
+ Hits        18387    22730    +4343     
- Misses      39466    51930   +12464     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 28 '24 15:03 codecov[bot]