doctr icon indicating copy to clipboard operation
doctr copied to clipboard

Published 20 hours ago • verified publisher icon drdoctr

fix travis pr check

Open techgaun opened this issue 8 years ago • 4 comments

based on the docs : https://docs.travis-ci.com/user/environment-variables/

TRAVIS_PULL_REQUEST: The pull request number if the current job is a pull request, “false” if it’s not a pull request.

This closes #199

techgaun avatar Jun 21 '17 17:06 techgaun

I think the test failure is relevant here.

asmeurer avatar Jun 21 '17 17:06 asmeurer

oh crap I will check it out @asmeurer

techgaun avatar Jun 21 '17 18:06 techgaun

@asmeurer seems like this requires some more thought as I don't think https://github.com/drdoctr/doctr/blob/421aefdc0246713727f50d17669ff4f0efda684c/doctr/main.py#L270 would work. It would work for branch within the same repo but not on a different repo (like my fork for eg.). What do you suggest in this scenario?

techgaun avatar Jun 21 '17 18:06 techgaun

Hmm. It seems really that should be use the merge commit generated by Travis, not the original branch.

asmeurer avatar Jun 21 '17 18:06 asmeurer