doctr icon indicating copy to clipboard operation
doctr copied to clipboard

Support for other CIs

Open asmeurer opened this issue 7 years ago • 15 comments

In particular, GitLab and Circle are popular.

asmeurer avatar May 10 '17 21:05 asmeurer

Info for encrypted variables in Circle: https://github.com/circleci/encrypted-files

gforsyth avatar May 11 '17 15:05 gforsyth

If any of them let us upload a key directly we should do that.

asmeurer avatar May 11 '17 17:05 asmeurer

With circle we would still be uploading the key to github, no? gitlab is a different beast.

gforsyth avatar May 11 '17 23:05 gforsyth

I mean getting the key onto the CI. Everything would still use gh-pages. I don't know if Circle or GitLab support uploading the key directly, so that we don't have to encrypt it ourselves. Travis supports this, but only for private accounts (c.f. https://github.com/travis-ci/travis-ci/issues/7420).

asmeurer avatar May 12 '17 01:05 asmeurer

This page claims that a deploy key is added automatically. I'm guessing they are set as read-only, so I don't know if that can be changed. If not, this page claims that you can add ssh keys.

It looks like GitLab CI requires that we do basically the same thing that we do on Travis.

asmeurer avatar May 12 '17 02:05 asmeurer

This is awesome! We use GitLab a bit so it would be great to have this!

CJ-Wright avatar May 23 '17 15:05 CJ-Wright

I think this is the relevant API call for GitLab CI.

asmeurer avatar Jun 05 '17 20:06 asmeurer

GitLab is hard just because, as far as I can tell, you can't actually integrate GitLab CI with GitHub. That means we could still implement the feature, but we would be unable to test it for this repo.

asmeurer avatar Jul 15 '17 17:07 asmeurer

Does the project need a gitlab repo for testing with gitlabCI?

CJ-Wright avatar Jul 16 '17 13:07 CJ-Wright

We can set up a GitLab repo easily enough. The problem is that we'd like to have continuous testing of doctr itself, so that whenever we make changes to doctr, we can be reasonably sure that the GitLab stuff isn't breaking.

asmeurer avatar Jul 16 '17 14:07 asmeurer

I made a GitLab group https://gitlab.com/doctr

asmeurer avatar Jul 16 '17 14:07 asmeurer

Can you run the CI on gitlab and then look at the badge before accepting the PR? It would be nice if there was a PR feature looked Travis that showed of the gitlab build passed.

CJ-Wright avatar Jul 16 '17 15:07 CJ-Wright

Yeah as far as I saw there's no way to use GitLab CI as GitHub status checks.

asmeurer avatar Jul 16 '17 16:07 asmeurer

For Azure Pipelines: https://github.com/Microsoft/azure-pipelines-tasks/issues/9172#issuecomment-466024682

asmeurer avatar Jul 14 '19 20:07 asmeurer

Also https://github.com/drdoctr/doctr/issues/346

asmeurer avatar Jul 14 '19 20:07 asmeurer