doctr icon indicating copy to clipboard operation
doctr copied to clipboard

Does it make sense to use doctr to push with .nojekyll?

Open ocefpaf opened this issue 9 years ago • 5 comments

Right now doctr hardcodes a no .nojekyll as the design is to upload HTML pages to gh-pages. But what if one wants to use doctr to manage a page but still wants let GitHub build it? Should the .nojekyll be an option?

ocefpaf avatar Oct 24 '16 13:10 ocefpaf

Hey @ocefpaf, yes, I think that makes sense to make it an option. We hard-coded it to match our initial use-cases, but we're moving beyond those now. I think I would still like to have the .nojekyll put there by default, but it should be an option to disable it. I'm open to suggestions/differences of opinion on this, though.

gforsyth avatar Oct 24 '16 13:10 gforsyth

I think I would still like to have the .nojekyll put there by default

:+1:

This option would save me from issue the jekyll build command manually and, better yet, from changing the Travis-CI language to ruby just to get jekyll build. I will try a PR later today.

ocefpaf avatar Oct 24 '16 13:10 ocefpaf

I believe if only happens once, when doctr creates gh-pages if it doesn't exist. So you can manually remove it if you don't want it. An option seems like overkill, since it would be ignored after the first run. Maybe we just need some documentation.

asmeurer avatar Oct 24 '16 17:10 asmeurer

I agree that an option is an overkill but removing it afterwards seems like a hack. Maybe this could be something that happens at doctr configure time.

ocefpaf avatar Oct 24 '16 17:10 ocefpaf

It's not a hack. Doctr is only in charge of the directory it deploys to. You are free to modify gh-pages outside that directory however you want (or more precisely, it is in charge of the files it deploys, so even if the directory is . it doesn't care about .nojekyll unless that is one of the files it deploys).

asmeurer avatar Oct 24 '16 18:10 asmeurer