net-http-persistent icon indicating copy to clipboard operation
net-http-persistent copied to clipboard

Question on Keep-Alive header

Open dadah89 opened this issue 3 years ago • 0 comments

hi! Have a question on the Keep-Alive header.

I see in https://github.com/drbrain/net-http-persistent/blob/master/lib/net/http/persistent.rb#L943 that the header is set to a value (30 by default), so it'll send a header like Keep-Alive: 30.

But looking at the specification for the Keep-Alive header looks like it expects to be set with directives (e.g. timeout=30) instead of a number:

  • https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Keep-Alive#directives
  • https://www.rfc-editor.org/rfc/rfc2068.html#section-19.7.1.1
  • https://tools.ietf.org/id/draft-thomson-hybi-http-timeout-01.html#rfc.section.2

Is that conclusion correct? Or am I mixing up things and not looking at the correct references docs?

Thanks!

dadah89 avatar Apr 19 '22 16:04 dadah89