Ben Morgan
Ben Morgan
Modulo fixing any errors in the CI, I think this is close to ready. I guess the last step is unit tests for when the optical physics are enabled (they...
Having played a bit with the tests as above, one slight interface smell (depending on point of view) with the use of `std::optional` is that setting options through the top...
@stognini I'll implement your suggestions in a fresh PR!
I'm happy to be added as a preliminary contact point if you want here as I'm officially in LEGEND.
It depends... Between runs, Geant4 is in its "idle" state and so the geometry can completely change, the physics can change in certain aspects like parameters and (de)activation of some...
@sethrj, given the update in drbenmorgan/celer-adept#6, should we close this? Or leave open to note as a possible feature for the future if a hard requirement comes along?
As @arceciemat suggests this is already possible, closing on this basis, but please reopen if more discussion is needed.
> * Where should I put `begin_run` so that it's after all threads have been allocated? Maybe just on the last thread to call `BeginOfRunAction`? (But I assume one thread...
As @arce suggests this as a "WONTFIX" I'm going to close for now, but please reopen if more discussion needed
Hi @jrmadsen, looking at the CI failures, I don't think they're related to the changes here but let me know if not!