drawdb icon indicating copy to clipboard operation
drawdb copied to clipboard

Fix to comments visualization in tables and fields popovers

Open santilapi13 opened this issue 1 year ago • 2 comments

I saw issue #26 and I didn't catch what it was refering to (maybe some about bringing comments from SQL code?), but I found out a few bugs in comments display while you hover the mouse over tables and tables' fields.

  • If a word in a table comment (in the SidePanel) was too long, it would get out of the popover. I fixed it by adding wordBreak:"break-word" to the Popover's style property.
  • While hovering a field in any table, it would display all its properties except for its comment, so I added it below "Default" section, adding the word-breaking fix too.

This is not a big deal but it would be my first contribution ever, so I hope it helps.

santilapi13 avatar Apr 11 '24 22:04 santilapi13

@santilapi13 is attempting to deploy a commit to the dottle's projects Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 11 '24 22:04 vercel[bot]

Hello! Thank for the contribution.

I can't reproduce the overflow bug image

1ilit avatar Apr 12 '24 00:04 1ilit

I've just committed suggested changes, but I don't know how to make the pull request again, nor if I have to do it 😅

The "overflow bug" happened with long but non-existent words, for example "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa".: image

Breaking words solves this problem: image

As you said, I changed the comment div style instead of the Popover style. I gave it a max width so that it grows to a certain point, but it also keeps small if there are only a few words. Now, the UI doesn't break any more. Finally, I also changed "Not comment" to "No comment". Here you have some pictures.

Field1

Field2

Field3

santilapi13 avatar Apr 12 '24 02:04 santilapi13

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drawdb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2024 6:57am

vercel[bot] avatar Apr 14 '24 06:04 vercel[bot]