drathier

Results 85 comments of drathier

0.15.7 based release available at https://github.com/drathier/purescript/releases/tag/v0.15.7-caching-15 0.0.19 based purerl release available at https://github.com/drathier/purerl/releases/tag/v0.0.19-caching-15 - note that that is built from a different branch than this is - passes ci tests...

# Current status of this POC We're still using this for all development, fyi. I'm mostly waiting for the combination of: - me having enough free time to work on...

Please allow hex input of colors, rather than adding one more color scheme :)

Sorry. I've failed to explain it properly, because multiple people have looked at the code in that PR without reading the comment thread first. I'd be more than happy for...

Yes, I'll try to find the time to review it this week. The main idea behind the caching strategy we're using is: 1. each module exports everything that's public in...

Printing the reason why something recompiled helps people debug slow compile times. Likewise printing if compilation of a particular module took more than e.g. 10s, or printing the 10 slowest-to-compile...

Lmk when you want another review pass :) Please fix or reply to all review comments before

Sorry about the late response. Life happened. I think we're missing these kinds of "compile, get error, fix error, recompile" regression tests? Please add :) - https://github.com/drathier/purserl/blob/single-binary/tests/TestMake.hs#L244 - https://github.com/drathier/purserl/blob/single-binary/tests/TestMake.hs#L268 -...

To clarify, in case there was a misunderstanding. In order to merge this, I'd like at least the linked tests to be ported over, as they're actual regressions seen in...

@wclr I did a pass over my review comments to see which ones were done. I'm apparently not allowed to mark my own comments as resolved, and it felt weird...