com.drastikbydesign.stripe icon indicating copy to clipboard operation
com.drastikbydesign.stripe copied to clipboard

Published 20 hours ago • verified publisher icon drastik

Contribution fails with 100% discount and only Stripe

Open peoute opened this issue 7 years ago • 3 comments

If Stripe is the only form of payment, and someone uses a 100% discount code (CiviDiscount), I get an error because Stripe expects payment info and of course the user isn't putting it in for $0.

@h-c-c has been able to reproduce the error for this use case, fwiw.

peoute avatar May 18 '17 16:05 peoute

We confirm the issue on Civicrm 4.7.19 and stripe-4.7-dev. We tested the "fix" mentioned on that page https://github.com/drastik/com.drastikbydesign.stripe/issues/211 but same result.

danielchat avatar Jun 20 '17 01:06 danielchat

I had the same problem - I applied #211 but also uncommented the return true line at the end, and now it works.

jmcclelland avatar Jun 20 '17 19:06 jmcclelland

@jmcclelland Using currentTotal doesn't seem to work consistently if the default priceset item isn't the item that has the discount. I've used calculateTotalFee() instead.

My PR https://github.com/drastik/com.drastikbydesign.stripe/pull/252

herbdool avatar Apr 10 '18 21:04 herbdool