Daniel Rasmussen

Results 68 comments of Daniel Rasmussen

Maybe look into this as part of a larger Nengo ecosystem benchmarking project.

Notes from meeting: Only allow this on neuron-to-neuron connections (not NEF connections)

I think the easiest and cleanest solution is just to raise the Exception and let the user fix their code. Hiding the error behind a warning seems equally likely to...

After some more discussion, we think this is the desired behaviour (for now). Allowing n_neurons to change post-initialization can introduce all kinds of errors, and the errors tend to be...

Unfortunately master looks like it has the same behaviour. You can see an example of the missing lines here https://codecov.io/gh/nengo/nengo/src/template-ci/nengo/base.py (that file has 100% coverage when not running through `pytest-cov`)....

I'm testing it with and without xdist. You can see without xdist here: https://travis-ci.org/nengo/nengo/jobs/510953456#L917 (69% coverage) and without xdist, without pytest-cov here: https://travis-ci.org/nengo/nengo/jobs/510953456#L1214 (82% coverage) We do eventually want to...

No change after removing the entrypoint, unfortunately.

That helped me track the issue down to this line https://github.com/nengo/nengo/blob/master/setup.cfg#L41, which I had forgotten we were setting. So that definitely makes sense that early-loading that file would mess up...

Manually starting the pytest-cov engine as in https://pytest-cov.readthedocs.io/en/latest/plugins.html solved the problem for me, thanks! I swear I tried that before, but I must have had some other changes happening at...

Minor update: I found that manually starting the pytest-cov engine works, _unless_ we use one of the options defined in the plugin that we're trying to get pytest-cov to load...