draper icon indicating copy to clipboard operation
draper copied to clipboard

Cleanup: Initialize instance variable before use to avoid Ruby warnings

Open olleolleolle opened this issue 4 years ago • 7 comments

Description

This avoids a Ruby warning emitted on use.

By initializing the variable before use, this is an easy win against the sea of warnings output.

Testing

  1. Run the test with RUBYOPT=-W2
  2. See that @decorated_collection is not among the output

olleolleolle avatar Apr 03 '20 12:04 olleolleolle

Hi there! Any news?

n-rodriguez avatar Dec 22 '20 04:12 n-rodriguez

Ping @codebycliff

n-rodriguez avatar Jan 14 '21 01:01 n-rodriguez

@olleolleolle can you please rebase your branch on master?

n-rodriguez avatar Jan 21 '21 20:01 n-rodriguez

I could make an attempt, in about 12 hours.

But I can hit the Update Branch button right now. If green, you could Squash commits Into One Commit, using the merge button variant for that.

olleolleolle avatar Jan 21 '21 21:01 olleolleolle

Haha, the issue is created by: me defining a variable, so the test must be altered to match that new situation!

Update: I updated the test, changing it to match the current code.

olleolleolle avatar Jan 21 '21 21:01 olleolleolle

@olleolleolle thank you! Ping @codebycliff

n-rodriguez avatar Jan 22 '21 12:01 n-rodriguez

ping @codebycliff

n-rodriguez avatar May 01 '21 23:05 n-rodriguez