react-forms-processor icon indicating copy to clipboard operation
react-forms-processor copied to clipboard

Mark all fields touched

Open blabno opened this issue 7 years ago • 5 comments

When I submit the form and validation is failing I want all validation errors to be shown. So it would be great to tell the form to mark every field as touched.

blabno avatar Oct 18 '18 11:10 blabno

Thanks for raising this Bernard - and the associated PR. It's now the weekend for me (I'm in Sydney, Australia) so I won't do anything with the PR until Monday (so I can check the branch out and test it out). I've had a quick look and it looks good though so shouldn't be a problem to merge

This is definitely a good feature to add so I'm very happy that you've identified the issue and raised a PR for it - I'm really very grateful, thanks! 👍

draperd avatar Oct 19 '18 20:10 draperd

This feature got broken again. It was fixed in 0.0.22 and got broken in 0.0.26. I bet it's this commit: https://github.com/draperd/react-forms-processor/commit/5dd431d4119d09df2968c92e18ae60542b72121d

blabno avatar Nov 26 '18 14:11 blabno

Thanks for reporting this @blabno - is it still broken in 0.0.28 ? There have been subsequent changes to validation since that commit you referenced.

I have been trying to ensure we have unit tests to cover all the conditions but it might be that we have a shortfall in the tests.

draperd avatar Nov 27 '18 00:11 draperd

Yes, it exists in 28 as well.

Sent from ProtonMail mobile

-------- Original Message -------- On 27 Nov 2018, 01:29, Dave Draper wrote:

Thanks for reporting this @blabno - is it still broken in 0.0.28 ? There have been subsequent changes to validation since that commit you referenced.

I have been trying to ensure we have unit tests to cover all the conditions but it might be that we have a shortfall in the tests.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

blabno avatar Nov 27 '18 00:11 blabno

OK, apologies for the slow response on this - I should be able to look at this next week.

draperd avatar Nov 29 '18 08:11 draperd