sideberry: collapsed sidebar tab icon, tab container indicator, pinned tab margin left and width

[danielphan2003]

Firefox Info

Firefox Nightly 105.0a1, with default Firefox Sidebar extensions.

Issues

Collapsed sidebar tab icon is a rectangle instead of a square

Tab container indicator is actually 2px

Sideberry only displays it as 1px

Before	After

Relevant patch:

.container {
  margin: 0 auto auto 11px !important;
}

Pinned margin left is not specified

Also fix container indicator.

Before	After

Relevant patch:

.PinnedTabsBar .tab-wrapper {
  margin: 0-1px 0 11px !important;
}

Pinned tab width depends on tab title

Close icon is pushed further away.

Sideberry icon doesn't show up, whether CSD is enabled or not

See #22

[danielphan2003]

Huh, after writing the patch for tab container indicator, I tried to reproduce again by importing this repo and after that reapplied my patch but it didn't work. It did work in devtools though.

[drannex42]

This is interesting, because a lot of these issues I am not seeing even on an entirely new device with a fresh install (and on Windows, not Linux as I normally use).

I have noticed some new issues crop up with Windows, is this the OS you are using?

I need to submit a few new patches, but have been rather busy the past few weeks.

A quick fix for the rectangle issue is set in sideberry styles :: --tabs-height: 35px !Important; I've been meaning to push that out.

[danielphan2003]

This is interesting, because a lot of these issues I am not seeing even on an entirely new device with a fresh install (and on Windows, not Linux as I normally use).

I have noticed some new issues crop up with Windows, is this the OS you are using?

I'm on Linux (NixOS) and I'm using swaywm. I remember having cloned the repo on my Windows machine, but I will get back when I check it out to see if the issues are appearing on Windows as well.

I need to submit a few new patches, but have been rather busy the past few weeks.

A quick fix for the rectangle issue is set in sideberry styles :: --tabs-height: 35px !Important; I've been meaning to push that out.

Thanks, I will try it out to see if that fixes the rectangle issue.