Bernhard Schuster
Bernhard Schuster
> Hi, thanks for taking the time! So a sanity check of the general implementation would be great: > ## Properties > > There is not anymore any distinction between...
Notify @bminixhofer
> > The biggest issue using this library currently is the fact, that on each startup a lot of regular expressions are compiled. > > That is quite subjective :)...
I took the lazy path and below is the current flamegraph of `cargo-spellcheck` w/ `0.5.3` and you are correct, most time is spent in deserialization which is quite unfortunate. [flamegraph.svg](https://minio.spearow.io/nlprule-flames/flamegraph.svg?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=U3SW6059ITW4NFW5KR43%2F20210407%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20210407T085022Z&X-Amz-Expires=604800&X-Amz-SignedHeaders=host&X-Amz-Signature=74094e3623dee6b7de694df58e998f826482aa2008de059f407b583a0b9b521a)...
tl;dr need a good test case to improve this for real. --- My measurements really were only a few runs of cargo-spellcheck on the same file with different impls, and...
Some more digging revealed that the data really is very sparse. We do 2 allocations for structure and the intermediate combinator key, where everything holds 1 element only in 99%...
> Thanks for looking into this! > > > Vec for the inner 2 layers should already give a pretty good speedup. > > > Another approach would be to...
That'd be much appreciated, I'll have some time tomorrow night to look into this further.
Adding to the list of nice to haves: * avoid hindrance of cloning - current the regex engine used is not clone * provide more iterators and avoid allocations *...
https://github.com/billyrieger/bimap-rs/issues/27 needs a fix so `fnv` can be used to speedup lookups given all the tiny key sizes.