Stash-Reviewers-Chrome-Extension icon indicating copy to clipboard operation
Stash-Reviewers-Chrome-Extension copied to clipboard

CheckForUpdate is failing, Cant reach github message is showed

Open davidbaena opened this issue 6 years ago • 5 comments

Hello! When I updated the plugin to 2.2.14 version(Mac 10.13.2) I got the following dialog:

New version of the extension (cant.reach.github)
Please check you added your bitbucket server domain to extension manifest.json

It seems like chrome can't reach github in order to check the last version of the plugin. This request returns a undefined response in data:

window.communication.runtime.sendMessage(window.chromeExtId, {
					method: 'GET',
					action: 'xhttp',
					url: 'https://raw.githubusercontent.com/dragouf/Stash-Reviewers-Chrome-Extension/master/version'
				}, function(data) {
					if(!data) {
						data = {
							response: 'cant.reach.github'
						};
					}

But the endpoint works fine if i get this URL from chrome. It responses 2.2.14 version

How can solve it? I don't know how to add the bitbucket server to the manifest.

davidbaena avatar Jul 06 '18 08:07 davidbaena

I'm getting this message, too.

ggabdol avatar Jul 06 '18 15:07 ggabdol

I think this check is useless. It was used when this extension was self hosted. I will remove it.

dragouf avatar Jul 09 '18 06:07 dragouf

I'm getting this message, too.

karpach avatar Jul 09 '18 17:07 karpach

I stopped getting this message, but now I'm getting a new one related to the PR list view. I'll make a new issue around it.

cnnranderson avatar Jul 11 '18 17:07 cnnranderson

Version 2.2.15 and this issue still occurs.

edwinramirez avatar Feb 13 '19 17:02 edwinramirez