Stash-Reviewers-Chrome-Extension
Stash-Reviewers-Chrome-Extension copied to clipboard
dragouf
Pull request filters aren't working
When I'm viewing pull requests, the Open/Merged/Declined dropdown works fine, but adding users to the Authors/Reviewers/etc. filters doesn't have any effect. The search/add user functionality is fine but the filter doesn't seem to do anything.
My expectation is that adding a single user to the Authors Filter would show pull requests only from that author. The actual result is the exact same list as before the filter was changed.
I don't have a solution for that (yet), due to Qt limitation for this kind of widget. Any (viable) suggestion is very welcome. Any contribution is even more welcome :)
I do have local changes that work around the LINEAR_UINT32 case by using QDoubleSpinBox. On IEEE 754 systems (pretty much all of them theses days) double is exact for integers up to $2^{53}$, so that could cover some more ground if we can choose the widget dynamically instead of at compile time.
I think I already tried to have dynamic change (in a branch where I worked on plugins, specifically for custom control display) and it was a real pain (eg. it didn't work).
Maybe I can reprioritize plugins so I have a working ground for dynamic control widget.