kraft icon indicating copy to clipboard operation
kraft copied to clipboard

Some preparations for KDE6/QT6

Open t-8ch opened this issue 1 year ago • 4 comments

These are some cleanups I encountered when trying to build for KDE6/QT6. Most of them are already applicable today.

Feel free to pick up single commits now, or incorporate them into your migration work.

t-8ch avatar Aug 18 '24 13:08 t-8ch

Thanks a lot, that is very appreciated.

FYI, my plan is as follows: I am currently working on the (already way to big) branch newshared for Kraft 2.0 as described in the discussion. Once that is mergeable, it will be merged to master. Than, the port to Qt6 can happen on master easily.

The stable 1.x version will be maintained in a branch after that.

dragotin avatar Aug 19 '24 15:08 dragotin

Would you mind rebasing this one to see if the actions run through? Thanks!

dragotin avatar Sep 27 '24 18:09 dragotin

It didn't work. But it should be fixable in a reasonable manner.

t-8ch avatar Sep 27 '24 20:09 t-8ch

That seems to have worked. I dropped the breaking commit, and will see what is the issue.

t-8ch avatar Sep 28 '24 18:09 t-8ch

@t-8ch the branch https://github.com/dragotin/kraft/tree/portqt6_1 now builds against qt6 and also works with KF6. That makes this particular PR a bit redundant, but would you mind double checking the cmake files in the branch if you have a minute? Thanks a lot.

dragotin avatar Dec 23 '24 22:12 dragotin

@dragotin Looks good in general.

Testing seems to be broken when building out of tree. Changing the test definitions to add_test(NAME t_unitman COMMAND t_unitman) fixes it as it refers to the actual target.

t-8ch avatar Dec 23 '24 22:12 t-8ch

Drop cmake_minimum_required() from tests/CMakeLists.txt.

t-8ch avatar Dec 23 '24 22:12 t-8ch