nydus icon indicating copy to clipboard operation
nydus copied to clipboard

storage: retry timeout chunks for fscache ondemand path

Open kevinXYin opened this issue 3 years ago • 7 comments

for fscache ondemand path, if some requested chunks are set to pending by prefetch threads, and wait them timeout, will casue EIO to container side.

retry the timeout chunks on ondemand path, minimize EIOs.

Signed-off-by: Xin Yin [email protected]

kevinXYin avatar Oct 10 '22 13:10 kevinXYin

@kevinXYin , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/25903

anolis-bot avatar Oct 10 '22 13:10 anolis-bot

@kevinXYin , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch:white_check_mark: SUCCESS
build-docker-image:white_check_mark: SUCCESS
compile-nydus:white_check_mark: SUCCESS
compile-ctr-remote:white_check_mark: SUCCESS
compile-nydus-snapshotter:white_check_mark: SUCCESS
start-nydus-snapshotter-config-containerd:white_check_mark: SUCCESS
run-container-with-nydus-image:white_check_mark: SUCCESS

Congratulations, your test job passed!

anolis-bot avatar Oct 10 '22 13:10 anolis-bot

@kevinXYin , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/25933

anolis-bot avatar Oct 11 '22 02:10 anolis-bot

@kevinXYin , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch:white_check_mark: SUCCESS
build-docker-image:white_check_mark: SUCCESS
compile-nydus:white_check_mark: SUCCESS
compile-ctr-remote:white_check_mark: SUCCESS
compile-nydus-snapshotter:white_check_mark: SUCCESS
start-nydus-snapshotter-config-containerd:white_check_mark: SUCCESS
run-container-with-nydus-image:x: FAIL

Sorry, your test job failed. Please get the details in the link.

anolis-bot avatar Oct 11 '22 02:10 anolis-bot

/retest

changweige avatar Oct 12 '22 10:10 changweige

@changweige , the test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/26268

anolis-bot avatar Oct 12 '22 10:10 anolis-bot

@changweige , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch:white_check_mark: SUCCESS
build-docker-image:white_check_mark: SUCCESS
compile-nydus:white_check_mark: SUCCESS
compile-ctr-remote:white_check_mark: SUCCESS
compile-nydus-snapshotter:white_check_mark: SUCCESS
start-nydus-snapshotter-config-containerd:white_check_mark: SUCCESS
run-container-with-nydus-image:white_check_mark: SUCCESS

Congratulations, your test job passed!

anolis-bot avatar Oct 12 '22 10:10 anolis-bot

I didn't figure out why wait_for_range_ready is called after synchronous pulls of chunks. It looks like somewhat of a validation. But I am afraid something is wrong if wait_for_range_ready returns timeout ERROR since it is called after a synchronous download. It should always return true immediately.

changweige avatar Oct 28 '22 01:10 changweige