nydus icon indicating copy to clipboard operation
nydus copied to clipboard

nydus-image: refactor subcommand "inspect"

Open YushuoEdge opened this issue 3 years ago • 4 comments

The code for "nydus-image inspect" are refactored using standard API in RAFS.

Signed-off-by: YushuoEdge [email protected]

YushuoEdge avatar Aug 13 '22 12:08 YushuoEdge

@YushuoEdge , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/18269

anolis-bot avatar Aug 13 '22 12:08 anolis-bot

@YushuoEdge , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch:white_check_mark: SUCCESS
build-docker-image:white_check_mark: SUCCESS
compile-nydus:white_check_mark: SUCCESS
compile-ctr-remote:white_check_mark: SUCCESS
compile-nydus-snapshotter:white_check_mark: SUCCESS
start-nydus-snapshotter-config-containerd:white_check_mark: SUCCESS
run-container-with-nydus-image:white_check_mark: SUCCESS

Congratulations, your test job passed!

anolis-bot avatar Aug 13 '22 12:08 anolis-bot

@changweige can you please take a look?

liubogithub avatar Aug 15 '22 00:08 liubogithub

@changweige can you please take a look?

Sure. will take a glance

changweige avatar Aug 15 '22 01:08 changweige

I am experiencing this refactored tool but got the below error, which I think chunk info should be correctly shown about its blob id and chunk index in one blob.

Shall we continue reviewing the PR until they are fixed?

For symlink file:

Inspecting Rafs :> stat run
[2022-08-17 09:49:51.162030 +08:00] ERROR [error/src/error.rs:21] Error:
	"invalid chunk info"
	at rafs/src/metadata/direct_v6.rs:956
	note: enable `RUST_BACKTRACE=1` env to display a backtrace
Failed in executing command, No such file or directory (os error 2)

For regular file:

Inspecting Rafs :> stat btmp
[2022-08-17 09:52:57.778269 +08:00] ERROR [/home/gechangwei/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/log-panics-2.1.0/src/lib.rs:130] thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Custom { kind: NotFound, error: "No such file or directory (os error 2): rafs/src/metadata/direct_v6.rs:753" }': rafs/src/metadata/direct_v6.rs:1141
   0: backtrace::capture::Backtrace::create
   1: backtrace::capture::Backtrace::new

changweige avatar Aug 17 '22 01:08 changweige

changweige

Sorry for that. I did not find the problem when I did test before. Maybe something went wrong when I rebase to master branch, please allow me to check again and revise.

YushuoEdge avatar Aug 17 '22 12:08 YushuoEdge

@YushuoEdge , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/19319

anolis-bot avatar Aug 27 '22 10:08 anolis-bot

@YushuoEdge , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch:white_check_mark: SUCCESS
build-docker-image:white_check_mark: SUCCESS
compile-nydus:white_check_mark: SUCCESS
compile-ctr-remote:white_check_mark: SUCCESS
compile-nydus-snapshotter:white_check_mark: SUCCESS
start-nydus-snapshotter-config-containerd:white_check_mark: SUCCESS
run-container-with-nydus-image:white_check_mark: SUCCESS

Congratulations, your test job passed!

anolis-bot avatar Aug 27 '22 10:08 anolis-bot

Please rebase your PR to get cargo deny passed

changweige avatar Aug 29 '22 06:08 changweige

@YushuoEdge , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/19487

anolis-bot avatar Aug 29 '22 14:08 anolis-bot

@YushuoEdge , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch:white_check_mark: SUCCESS
build-docker-image:white_check_mark: SUCCESS
compile-nydus:white_check_mark: SUCCESS
compile-ctr-remote:white_check_mark: SUCCESS
compile-nydus-snapshotter:white_check_mark: SUCCESS
start-nydus-snapshotter-config-containerd:white_check_mark: SUCCESS
run-container-with-nydus-image:white_check_mark: SUCCESS

Congratulations, your test job passed!

anolis-bot avatar Aug 29 '22 15:08 anolis-bot

Updates: @YushuoEdge is working on smoke testing and fixing. :)

imeoer avatar Sep 16 '22 02:09 imeoer

@YushuoEdge , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/21637

anolis-bot avatar Sep 18 '22 06:09 anolis-bot

@YushuoEdge , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch:white_check_mark: SUCCESS
build-docker-image:white_check_mark: SUCCESS
compile-nydus:x: FAIL

Sorry, your test job failed. Please get the details in the link.

anolis-bot avatar Sep 18 '22 06:09 anolis-bot

@YushuoEdge , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/21638

anolis-bot avatar Sep 18 '22 06:09 anolis-bot

update: The request_mode output of cmd stats, prefetch, blobs are used in smoke test. More tests result can refer to: https://docs.google.com/document/d/115r90YmZmRPKxEz6WEfGHD6F6eylv4lQDe-7xd_pTUI/edit?usp=sharing

YushuoEdge avatar Sep 18 '22 06:09 YushuoEdge

@YushuoEdge , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch:white_check_mark: SUCCESS
build-docker-image:white_check_mark: SUCCESS
compile-nydus:white_check_mark: SUCCESS
compile-ctr-remote:white_check_mark: SUCCESS
compile-nydus-snapshotter:white_check_mark: SUCCESS
start-nydus-snapshotter-config-containerd:white_check_mark: SUCCESS
run-container-with-nydus-image:x: FAIL

Sorry, your test job failed. Please get the details in the link.

anolis-bot avatar Sep 18 '22 06:09 anolis-bot

@YushuoEdge , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/21641

anolis-bot avatar Sep 18 '22 08:09 anolis-bot

@YushuoEdge , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch:white_check_mark: SUCCESS
build-docker-image:white_check_mark: SUCCESS
compile-nydus:white_check_mark: SUCCESS
compile-ctr-remote:white_check_mark: SUCCESS
compile-nydus-snapshotter:white_check_mark: SUCCESS
start-nydus-snapshotter-config-containerd:white_check_mark: SUCCESS
run-container-with-nydus-image:x: FAIL

Sorry, your test job failed. Please get the details in the link.

anolis-bot avatar Sep 18 '22 09:09 anolis-bot

update: The request_mode output of cmd stats, prefetch, blobs are used in smoke test. More tests result can refer to: https://docs.google.com/document/d/115r90YmZmRPKxEz6WEfGHD6F6eylv4lQDe-7xd_pTUI/edit?usp=sharing

Thanks for adding the test case in smoke testing, it is difficult for us to cover all the tests of inspect command, a few basic checks are enough, what do you think? cc @changweige @bergwolf

imeoer avatar Sep 19 '22 03:09 imeoer