nydus icon indicating copy to clipboard operation
nydus copied to clipboard

dependency: remove dependency on serde-with

Open jiangliu opened this issue 3 years ago • 14 comments

Remov dependency on serde-with by open-coding, which gets rid of: Removing darling v0.13.4 Removing darling_core v0.13.4 Removing darling_macro v0.13.4 Removing ident_case v1.0.1 Removing serde_with v1.14.0 Removing serde_with_macros v1.5.2 Removing strsim v0.10.0

Signed-off-by: Jiang Liu [email protected]

jiangliu avatar Jul 28 '22 10:07 jiangliu

@jiangliu , a new test job has been submitted. Please wait in patience. The test job url: None

anolis-bot avatar Jul 28 '22 10:07 anolis-bot

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch:white_check_mark: SUCCESS
build-docker-image:white_check_mark: SUCCESS
compile-nydus:x: FAIL

Sorry, your test job failed. Please get the details in the link.

anolis-bot avatar Jul 28 '22 10:07 anolis-bot

@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: None

anolis-bot avatar Jul 28 '22 15:07 anolis-bot

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch:white_check_mark: SUCCESS
build-docker-image:white_check_mark: SUCCESS
compile-nydus:white_check_mark: SUCCESS
compile-ctr-remote:white_check_mark: SUCCESS
compile-nydus-snapshotter:white_check_mark: SUCCESS
start-nydus-snapshotter-config-containerd:white_check_mark: SUCCESS
run-container-with-nydus-image:white_check_mark: SUCCESS

Congratulations, your test job passed!

anolis-bot avatar Jul 28 '22 16:07 anolis-bot

Sadly, this breaks nydusctl

gechangwei@n227-089-202 ~/git_repo/nydus-rs/contrib/nydus-test (serde-with)$ sudo nydusctl --sock api_sock info

Version:                "2.1.0-alpha2"
Status:                 "RUNNING"
Profile:                "release"
Commit:                 "2c6c75b766c5ae16340537bc3bfd645d27d10640"
Backend list:
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Error("premature end of input", line: 0, column: 0)', src/bin/nydusctl/commands.rs:351:69
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Aborted

changweige avatar Jul 29 '22 00:07 changweige

@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/17797

anolis-bot avatar Aug 08 '22 16:08 anolis-bot

Sadly, this breaks nydusctl

gechangwei@n227-089-202 ~/git_repo/nydus-rs/contrib/nydus-test (serde-with)$ sudo nydusctl --sock api_sock info

Version:                "2.1.0-alpha2"
Status:                 "RUNNING"
Profile:                "release"
Commit:                 "2c6c75b766c5ae16340537bc3bfd645d27d10640"
Backend list:
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Error("premature end of input", line: 0, column: 0)', src/bin/nydusctl/commands.rs:351:69
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Aborted

This issue should have been fixed.

jiangliu avatar Aug 08 '22 16:08 jiangliu

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch:white_check_mark: SUCCESS
build-docker-image:white_check_mark: SUCCESS
compile-nydus:white_check_mark: SUCCESS
compile-ctr-remote:white_check_mark: SUCCESS
compile-nydus-snapshotter:white_check_mark: SUCCESS
start-nydus-snapshotter-config-containerd:white_check_mark: SUCCESS
run-container-with-nydus-image:white_check_mark: SUCCESS

Congratulations, your test job passed!

anolis-bot avatar Aug 08 '22 16:08 anolis-bot

@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/17836

anolis-bot avatar Aug 09 '22 06:08 anolis-bot

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch:white_check_mark: SUCCESS
build-docker-image:white_check_mark: SUCCESS
compile-nydus:x: FAIL

Sorry, your test job failed. Please get the details in the link.

anolis-bot avatar Aug 09 '22 06:08 anolis-bot

failed cargo fmt

/home/gechangwei/.cargo/bin/cargo fmt -- --check
Diff in /data00/home/gechangwei/git_repo/nydus-rs/api/src/http.rs at line 846:
     from_api: Receiver<ApiResponse>,
 ) -> Result<(thread::JoinHandle<Result<()>>, Arc<Waker>)> {
     // Try to remove existed unix domain socket
-    let  _ = fs::remove_file(path);
+    let _ = fs::remove_file(path);
     let socket_path = PathBuf::from(path);

     let mut poll = Poll::new()?;
make: *** [Makefile:57: .format] Error 1

changweige avatar Aug 09 '22 06:08 changweige

Otherwise the format issue, LGTM

changweige avatar Aug 09 '22 06:08 changweige

@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/17850

anolis-bot avatar Aug 09 '22 06:08 anolis-bot

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch:white_check_mark: SUCCESS
build-docker-image:white_check_mark: SUCCESS
compile-nydus:white_check_mark: SUCCESS
compile-ctr-remote:white_check_mark: SUCCESS
compile-nydus-snapshotter:white_check_mark: SUCCESS
start-nydus-snapshotter-config-containerd:white_check_mark: SUCCESS
run-container-with-nydus-image:white_check_mark: SUCCESS

Congratulations, your test job passed!

anolis-bot avatar Aug 09 '22 07:08 anolis-bot

@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/18673

anolis-bot avatar Aug 18 '22 14:08 anolis-bot

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch:white_check_mark: SUCCESS
build-docker-image:white_check_mark: SUCCESS
compile-nydus:white_check_mark: SUCCESS
compile-ctr-remote:white_check_mark: SUCCESS
compile-nydus-snapshotter:white_check_mark: SUCCESS
start-nydus-snapshotter-config-containerd:white_check_mark: SUCCESS
run-container-with-nydus-image:white_check_mark: SUCCESS

Congratulations, your test job passed!

anolis-bot avatar Aug 18 '22 14:08 anolis-bot

@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/20972

anolis-bot avatar Sep 12 '22 08:09 anolis-bot

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch:white_check_mark: SUCCESS
build-docker-image:white_check_mark: SUCCESS
compile-nydus:white_check_mark: SUCCESS
compile-ctr-remote:white_check_mark: SUCCESS
compile-nydus-snapshotter:white_check_mark: SUCCESS
start-nydus-snapshotter-config-containerd:white_check_mark: SUCCESS
run-container-with-nydus-image:white_check_mark: SUCCESS

Congratulations, your test job passed!

anolis-bot avatar Sep 12 '22 08:09 anolis-bot

@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/21799

anolis-bot avatar Sep 19 '22 17:09 anolis-bot

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch:white_check_mark: SUCCESS
build-docker-image:white_check_mark: SUCCESS
compile-nydus:white_check_mark: SUCCESS
compile-ctr-remote:white_check_mark: SUCCESS
compile-nydus-snapshotter:white_check_mark: SUCCESS
start-nydus-snapshotter-config-containerd:white_check_mark: SUCCESS
run-container-with-nydus-image:white_check_mark: SUCCESS

Congratulations, your test job passed!

anolis-bot avatar Sep 19 '22 17:09 anolis-bot

@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/22001

anolis-bot avatar Sep 20 '22 12:09 anolis-bot

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch:white_check_mark: SUCCESS
build-docker-image:white_check_mark: SUCCESS
compile-nydus:white_check_mark: SUCCESS
compile-ctr-remote:white_check_mark: SUCCESS
compile-nydus-snapshotter:white_check_mark: SUCCESS
start-nydus-snapshotter-config-containerd:white_check_mark: SUCCESS
run-container-with-nydus-image:white_check_mark: SUCCESS

Congratulations, your test job passed!

anolis-bot avatar Sep 20 '22 12:09 anolis-bot

@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/22098

anolis-bot avatar Sep 21 '22 07:09 anolis-bot

@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/22099

anolis-bot avatar Sep 21 '22 07:09 anolis-bot

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch:white_check_mark: SUCCESS
build-docker-image:white_check_mark: SUCCESS
compile-nydus:white_check_mark: SUCCESS
compile-ctr-remote:white_check_mark: SUCCESS
compile-nydus-snapshotter:white_check_mark: SUCCESS
start-nydus-snapshotter-config-containerd:white_check_mark: SUCCESS
run-container-with-nydus-image:white_check_mark: SUCCESS

Congratulations, your test job passed!

anolis-bot avatar Sep 21 '22 07:09 anolis-bot

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch:white_check_mark: SUCCESS
build-docker-image:white_check_mark: SUCCESS
compile-nydus:white_check_mark: SUCCESS
compile-ctr-remote:white_check_mark: SUCCESS
compile-nydus-snapshotter:white_check_mark: SUCCESS
start-nydus-snapshotter-config-containerd:white_check_mark: SUCCESS
run-container-with-nydus-image:white_check_mark: SUCCESS

Congratulations, your test job passed!

anolis-bot avatar Sep 21 '22 07:09 anolis-bot

@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/22238

anolis-bot avatar Sep 21 '22 13:09 anolis-bot

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch:white_check_mark: SUCCESS
build-docker-image:white_check_mark: SUCCESS
compile-nydus:white_check_mark: SUCCESS
compile-ctr-remote:white_check_mark: SUCCESS
compile-nydus-snapshotter:white_check_mark: SUCCESS
start-nydus-snapshotter-config-containerd:white_check_mark: SUCCESS
run-container-with-nydus-image:x: FAIL

Sorry, your test job failed. Please get the details in the link.

anolis-bot avatar Sep 21 '22 13:09 anolis-bot

@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/22247

anolis-bot avatar Sep 21 '22 14:09 anolis-bot

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
nydus_ci:x: FAIL

Sorry, your test job failed. Please get the details in the link.

anolis-bot avatar Sep 21 '22 14:09 anolis-bot