nydus icon indicating copy to clipboard operation
nydus copied to clipboard

Move images annotations that need to be passed to snapshotter to snapshotter repo

Open changweige opened this issue 3 years ago • 2 comments

Nydus-snapshotter is being migrated from this repo to containerd organization. Right now, nydus-snapshotter depends on nydusify for using those image annotations. Those annotations' names is prefixed with containerd.io/snapshot, which will all be passed to snapshotter by containerd.

So better we move those annotations' definition to snapshotter

changweige avatar Jan 10 '22 10:01 changweige

Is this work done yet?

liubogithub avatar May 19 '22 08:05 liubogithub

@liubogithub not yet, but it's not a high priority.

imeoer avatar May 19 '22 08:05 imeoer

Finished in https://github.com/containerd/nydus-snapshotter/pull/351 Upstream related: https://github.com/containerd/containerd/pull/8036 and https://github.com/moby/moby/pull/44810

adamqqqplay avatar Mar 23 '23 06:03 adamqqqplay