nydus icon indicating copy to clipboard operation
nydus copied to clipboard

Bump nydus-snapshotter to v0.15.2 in go mod

Open Fricounet opened this issue 7 months ago • 1 comments

I'm trying to bump the version of the nydus-snapshotter used in nydusify for #1691 and #1692. However, when bumping the version to v0.15.2, the go compiler become unhappy because of ambiguous imports:

go: github.com/dragonflyoss/nydus/contrib/nydusify/pkg/committer imports
	github.com/containerd/containerd imports
	github.com/containerd/containerd/api/services/containers/v1: ambiguous import: found package github.com/containerd/containerd/api/services/containers/v1 in multiple modules:
	github.com/containerd/containerd v1.7.23 (/home/baptiste.girardcarrabin/go/pkg/mod/github.com/nydusaccelerator/[email protected]/api/services/containers/v1)
	github.com/containerd/containerd/api v1.8.0 (/home/baptiste.girardcarrabin/go/pkg/mod/github.com/containerd/containerd/[email protected]/services/containers/v1)

after digging, it seems that since nydus-snapshotter was moved to containerd-v2 in v0.15.0, there is now a conflict with the versions in use for nydusaccelerator/containerd and goharbor/acceleration-service which are still both using containerd v1. I think both must be updated for the version bump to work. To minimize having more dependency mess, I believe containerd v2.0.2 should be used everywhere.

TODO

  • [x] create branch on nydusaccelerator fork based on containerd v2.0.2 with all the cherry-picks
  • [ ] bump containerd in goharbor/acceleration-service to v2.0.2

Fricounet avatar May 27 '25 16:05 Fricounet

Thank for the feedback, nydusify has imported the forked containerd repo (nydusaccelerator/[email protected]) to introduce the chunked push feature, I have now squashed the redundant commits and pushed them to https://github.com/nydusaccelerator/containerd/commits/nydus. Moving forward, we will need to rebase against containerd v2.

imeoer avatar May 28 '25 02:05 imeoer

This issue is stale because it has been open 60 days with no activity.

github-actions[bot] avatar Aug 12 '25 00:08 github-actions[bot]

completed by #1746

Fricounet avatar Aug 28 '25 14:08 Fricounet