nydus icon indicating copy to clipboard operation
nydus copied to clipboard

fix: correct some bugs and add feature of backend config for optimize subcommand

Open Maxing1997 opened this issue 10 months ago • 3 comments

Details

There are some bugs in optimize subcommand, following bugs are fixed in this patchset:

  • read chunk from wrong blob
  • missing extended table in new bootstrap
  • hardlink is broken in new image
  • missing blobinfo updates
  • wrong chunk align for fs-version 5

By the way, implement the backend config support for optimize subcommand, thus we can read chunk on-demand during build process.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Documentation Update (if none of the other choices apply)

Maxing1997 avatar Jan 22 '25 08:01 Maxing1997

Codecov Report

:x: Patch coverage is 0% with 246 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 59.85%. Comparing base (f60e40a) to head (55e36f6). :warning: Report is 48 commits behind head on master.

Files with missing lines Patch % Lines
builder/src/optimize_prefetch.rs 0.00% 170 Missing :warning:
src/bin/nydus-image/main.rs 0.00% 53 Missing :warning:
contrib/nydusify/cmd/nydusify.go 0.00% 23 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1661      +/-   ##
==========================================
- Coverage   60.05%   59.85%   -0.21%     
==========================================
  Files         147      147              
  Lines       49624    49790     +166     
  Branches    47078    47222     +144     
==========================================
- Hits        29802    29800       -2     
- Misses      18040    18207     +167     
- Partials     1782     1783       +1     
Files with missing lines Coverage Δ
builder/src/lib.rs 63.15% <ø> (ø)
contrib/nydusify/cmd/nydusify.go 13.11% <0.00%> (-0.41%) :arrow_down:
src/bin/nydus-image/main.rs 0.58% <0.00%> (-0.01%) :arrow_down:
builder/src/optimize_prefetch.rs 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jan 22 '25 08:01 codecov[bot]

Can we add a usage in docs/nydusify.md for the nydusify optimize command?

imeoer avatar Jan 24 '25 02:01 imeoer

Can we add a usage in docs/nydusify.md for the nydusify optimize command?

Hi @Maxing1997, plz help move forward with merging this PR if you have time. :)

imeoer avatar Apr 23 '25 02:04 imeoer

This PR is stale because it has been open 60 days with no activity.

github-actions[bot] avatar Jul 27 '25 00:07 github-actions[bot]

This PR was closed because it has been stalled for 7 days with no activity.

github-actions[bot] avatar Aug 03 '25 00:08 github-actions[bot]

@imeoer Hi, can you reopen this pr, I have adapt the prefetch_files to json format。

Maxing1997 avatar Aug 29 '25 14:08 Maxing1997