nydus
nydus copied to clipboard
rafs: cleanup errors
Based on the error definition, InvalidData is preferable than InvalidInput.
Data not valid for the operation were encountered. Unlike [InvalidInput], this typically means that the operation parameters were valid, however the error was caused by malformed input data. For example, a function that reads a file into a string will error with InvalidData if the file's contents are not valid UTF-8.
Relevant Issue (if applicable)
If there are Issues related to this PullRequest, please list it.
Details
Please describe the details of PullRequest.
Types of changes
What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] Documentation Update (if none of the other choices apply)
Checklist
Go over all the following points, and put an x in all the boxes that apply.
- [ ] I have updated the documentation accordingly.
- [ ] I have added tests to cover my changes.
Codecov Report
:x: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 60.04%. Comparing base (365f13e) to head (89c9f28).
:warning: Report is 83 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| rafs/src/fs.rs | 0.00% | 5 Missing :warning: |
| rafs/src/metadata/direct_v6.rs | 0.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #1654 +/- ##
==========================================
- Coverage 60.05% 60.04% -0.01%
==========================================
Files 147 147
Lines 49624 49624
Branches 47078 47078
==========================================
- Hits 29802 29799 -3
- Misses 18040 18042 +2
- Partials 1782 1783 +1
| Files with missing lines | Coverage Δ | |
|---|---|---|
| api/src/config.rs | 86.33% <100.00%> (ø) |
|
| api/src/error.rs | 67.74% <ø> (ø) |
|
| rafs/src/metadata/direct_v6.rs | 44.01% <0.00%> (ø) |
|
| rafs/src/fs.rs | 34.19% <0.00%> (ø) |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Not really sure, it seems the changes break some CI tests due to IO errors: https://github.com/dragonflyoss/nydus/actions/runs/12311443544/job/34446727113?pr=1654
Thanks, let me figure it out. The error seems irrelevant, let me rebase and test it again.
This PR is stale because it has been open 60 days with no activity.
This PR is stale because it has been open 60 days with no activity.