nydus icon indicating copy to clipboard operation
nydus copied to clipboard

Unit tests fail on master branch with old Linux distribution

Open adamqqqplay opened this issue 1 year ago • 1 comments

Additional Information

The following information is very important in order to help us to help you. Omission of the following details may delay your support request or receive no attention at all.

Version of nydus being used (nydusd --version)

master branch@ 43e651802ddb0d9a0ccd5aae1673a92994824d3d

Version of nydus-snapshotter being used (containerd-nydus-grpc --version)

Kernel information (uname -r)

5.4.0-148-generic

GNU/Linux Distribution, if applicable (cat /etc/os-release)

NAME="Ubuntu" VERSION="20.04.6 LTS (Focal Fossa)" ID=ubuntu ID_LIKE=debian PRETTY_NAME="Ubuntu 20.04.6 LTS" VERSION_ID="20.04" HOME_URL="https://www.ubuntu.com/" SUPPORT_URL="https://help.ubuntu.com/" BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/" PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy" VERSION_CODENAME=focal UBUNTU_CODENAME=focal

containerd-nydus-grpc command line used, if applicable (ps aux | grep containerd-nydus-grpc)

client command line used, if applicable (such as: nerdctl, docker, kubectl, ctr)

make ut-nextest

Screenshots (if applicable)

image

image

Details about issue

Some unit test fails on Ubuntu 20 (kernel 5.4.0-148-generic), but they work fine on Ubuntu 22 (kernel 5.15.0-43-generic). Maybe these errors are expected? But for unit testing, the behavior should not change due to different kernel versions.

        FAIL [   0.068s] nydus-service blob_cache::tests::test_meta_blob
        FAIL [   0.060s] nydus-service block_device::tests::test_block_device

My opinion is that it would be best to fix these unit tests, or move them into integration tests.

adamqqqplay avatar May 25 '23 02:05 adamqqqplay

cc @jiangliu

imeoer avatar May 25 '23 02:05 imeoer