helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

wrong values in helm chart template

Open masikrus opened this issue 1 year ago • 1 comments

Bug report:

$ helm pull dragonfly/dragonfly $ tar -zxf dragonfly-1.1.33.tgz $ grep -r Values.metrics ./dragonfly/templates/ ./templates/manager/metrics-svc.yaml:{{ toYaml .Values.metrics.service.labels | indent 4 }} ./templates/seed-peer/metrics-svc.yaml:{{ toYaml .Values.metrics.service.labels | indent 4 }} ./templates/seed-client/metrics-svc.yaml:{{ toYaml .Values.metrics.service.labels | indent 4 }} ./templates/trainer/metrics-svc.yaml:{{ toYaml .Values.metrics.service.labels | indent 4 }} ./templates/scheduler/metrics-svc.yaml:{{ toYaml .Values.metrics.service.labels | indent 4 }}

i think should be .Values.${APPNAME}.metrics.service.labels

fix please

masikrus avatar Mar 21 '24 12:03 masikrus

@masikrus Pr is welcome.

yxxhero avatar Mar 31 '24 06:03 yxxhero