Dragonfly icon indicating copy to clipboard operation
Dragonfly copied to clipboard

add config for protocol and pattern

Open wangforthinker opened this issue 4 years ago • 4 comments

Signed-off-by: allen.wq [email protected]

Ⅰ. Describe what this PR did

Add config for protocol and pattern when dfdaemon starts with config.

Ⅱ. Does this pull request fix one issue?

NONE.

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

wangforthinker avatar Jun 01 '20 11:06 wangforthinker

Codecov Report

Merging #1373 into master will decrease coverage by 0.14%. The diff coverage is 5.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1373      +/-   ##
==========================================
- Coverage   51.80%   51.65%   -0.15%     
==========================================
  Files         135      136       +1     
  Lines        8803     8831      +28     
==========================================
+ Hits         4560     4562       +2     
- Misses       3866     3892      +26     
  Partials      377      377              
Impacted Files Coverage Δ
dfdaemon/config/config.go 100.00% <ø> (ø)
dfdaemon/proxy/pattern_matcher.go 0.00% <0.00%> (ø)
dfdaemon/proxy/proxy.go 10.48% <0.00%> (-0.05%) :arrow_down:
cmd/dfdaemon/app/root.go 67.00% <100.00%> (+0.67%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e8a6514...447e875. Read the comment docs.

codecov-commenter avatar Jun 01 '20 11:06 codecov-commenter

@inoc603 PTAL

lowzj avatar Jun 02 '20 04:06 lowzj

Add PatternMatcher to match url request to choose pattern. @inoc603 @lowzj PTAL.

wangforthinker avatar Jun 02 '20 12:06 wangforthinker

@wangforthinker I think we need some unit tests for PatternMatcher

inoc603 avatar Jun 15 '20 08:06 inoc603