dfly bench fails to parse dns

Open kostasrim opened this issue 7 months ago • 2 comments

The problem is:

Start cluster with 2 df nodes
Start dfly bench
Add a new node and start migrating some slots

DflyBench will crash because we do DnsResolve of the cluster nodes only once at the star. However because we added a new node and start migrating we get a MOVED new_node_dns and we take that address and we feed it to boost:make_address and it fails because we first need to call DnsResolve.

Jun 05 '25 10:06 kostasrim

The design of dfly_bench is not really ready for a cluster with shards added in the middle. It's because it has a predefined plan per connection of what to do and it's not really well defined of what needs to be done if a new shard is added in the middle and how many requests should we send there.

Jun 05 '25 10:06 romange

sounds good, we will see what we should do because we do need this 😄

// to be discussed internally

Jun 05 '25 10:06 kostasrim