dragonfly icon indicating copy to clipboard operation
dragonfly copied to clipboard

support for the command client-getname

Open boazsade opened this issue 2 years ago • 1 comments

Is your feature request related to a problem? Please describe. This is part of the client commands in Redis. This command is required in order to pass more tests in ioredis as they are checking for successfully testing these use case. For more details about this command - see client-getname

Describe the solution you'd like Supporting the command in dragonfly code base. Add unit test for it. Add system test for it (under tests/dragonfly) Verify its working by running:

docker build -t ioredis-test -f ./ioredis.Dockerfile .
docker run --rm -ti ioredis-test bash
## inside the container
mocha test/functional/*.ts -g 'should name the connection if options.connectionName is not null`

Describe alternatives you've considered There is no alternatives to this command. We would like to have this support in order to be compliment with ioredis.

Additional context We have support for client-setname, so this should be based on it.

boazsade avatar Nov 02 '22 14:11 boazsade

Once this is resolved, please update the ioredis tests that are not running!

boazsade avatar Nov 06 '22 07:11 boazsade