dragonfly icon indicating copy to clipboard operation
dragonfly copied to clipboard

`math.randomseed` has compatibility issue with certain apps

Open nadecancode opened this issue 1 year ago • 1 comments

Describe the bug It seems like the Lua version that Dragonfly has upgraded to does not take floats for math.randomseed, which the older versions of Lua have probably accounted for that behavior. This results Sentry's incompatibility with Dragonfly. @aarnaud has made a PR to Sentry https://github.com/getsentry/sentry/pull/65825/files but it seems like Sentry just let it stale without addressing the problem. It would be nice if Dragonfly can address this, since I suppose this should be a part of "full Redis compatibility".

To Reproduce Steps to reproduce the behavior: Use math.randomseed with a float

Expected behavior math.randomseed correctly converts float to integer internally and returns a seed

Screenshots If applicable, add screenshots to help explain your problem.

Reproducible Code Snippet https://github.com/getsentry/sentry/pull/65825/files#diff-b8fbfcdbe3cc5f51bb7b01328639cea8b1180a798e18ac03f3a5293e216bf47fL357

Additional context Add any other context about the problem here.

nadecancode avatar Oct 14 '24 16:10 nadecancode

@dranikpg can you please take a look? Is it possible to inject our own implementation of math.randomseed ?

romange avatar Oct 15 '24 06:10 romange

Yes, we can inject a custom implementation, we can also finally add support for redis log 🙂

dranikpg avatar Nov 07 '24 20:11 dranikpg

closing as it was merged into sentry

romange avatar Nov 27 '25 07:11 romange