dragonfly icon indicating copy to clipboard operation
dragonfly copied to clipboard

"wrong number of arguments" must be in lower case

Open romange opened this issue 2 years ago • 6 comments

Some testing frameworks expect this message in lower case. See below io-redis tests run.

image

romange avatar Oct 15 '22 01:10 romange

Hi I want to issue,please. Thx

LucianeFernandesRoque avatar Oct 18 '22 00:10 LucianeFernandesRoque

Send a pr then 🙂. Thanks

romange avatar Oct 18 '22 04:10 romange

Some testing frameworks expect this message in lower case. See below io-redis tests run.

image

in https://github.com/dragonflydb/dragonfly/edit/main/src/facade/facade.cc line 55 use tolower(cmd)

but i dont know if it works for not single chars too

Tomato6966 avatar Oct 18 '22 06:10 Tomato6966

Hi Guys, I dont know amuch about test, Usually jest, rspec. how can i run the tests? Sorry if my question is stupid

LucianeFernandesRoque avatar Oct 18 '22 17:10 LucianeFernandesRoque

This is a c++ project that requires good c++ knowledge to contribute. sorry.

romange avatar Oct 18 '22 17:10 romange

This is a c++ project that requires good c++ knowledge to contribute. sorry.

Sorry, @romange I thought I could do it, I have Ruby rails as my main language.. Thx

LucianeFernandesRoque avatar Oct 18 '22 21:10 LucianeFernandesRoque