dragonfly implement LMPOP

See here: https://valkey.io/commands/lmpop/

for more details

Oct 06 '24 12:10 adiholden

Hi, Could anyone please provide discription of this issue?

Oct 14 '24 09:10 SalmanDeveloperz

Hi, Could anyone please provide discription of this issue?

Done.

Oct 14 '24 09:10 romange

Hi, I have a few queries about the LMPOP implementation:

In which file or module should I add the new LMPOP command?
Is there any specific design pattern or guideline I should follow when implementing this command?
Should I also add test cases in the current testing framework?

Thanks for your guidance!

Oct 14 '24 09:10 SalmanDeveloperz

Hi @SalmanDeveloperz , you can checkout LPOP implemantion in list_family.cc, add the LMPOP command to this file and add unit tests in list_family_test.cc

Oct 14 '24 12:10 adiholden

Thanks for the guidance! I’d like to take on the implementation of the LMPOP command as discussed. Could you please assign this issue to me? Best Regards,

Oct 14 '24 13:10 SalmanDeveloperz

Hello @SalmanDeveloperz we do not assign issues to external contributors. Feel free to just send a PR and link it to this issue.

Oct 14 '24 13:10 romange

Hi, I've implemented the LMPOP command functionality in list_family.cc and added unit tests in list_family_test.cc. You can review the changes in my pull request: [Add LMPOP command implementation and unit tests]

Please let me know if you need any further modifications or if there's anything else I can assist with! Thanks

Oct 15 '24 02:10 SalmanDeveloperz