dragonfly icon indicating copy to clipboard operation
dragonfly copied to clipboard

Enable tx inline execution when snapshoting/journaling step 2 - Allow await on all journaling flows

Open adiholden opened this issue 1 year ago • 3 comments

Today on some flows we do not allow preemption when adding record to journal (we pass a flag to AddLogRecord if we allow await)

  • [x] we can remove the restriction to not allow await on non auto journal flows because now we do allow preemption inside callback exection.
  • [ ] remove the restriction within flow for expire and evict in heartbeat, this will require some code change in this flows
  • [ ] remove the NOOP opcode that just triggered journal writes to sync

adiholden avatar Oct 01 '24 12:10 adiholden

Closing this

kostasrim avatar Jan 27 '25 11:01 kostasrim

@kostasrim why did you close? I still see bool ServerState::AllowInlineScheduling() checking for journaling

romange avatar Jan 27 '25 11:01 romange

@romange I closed this because the bullet points within this issue have either been addressed or changed. Imo I don't remember exact the details so I will reopen here, jump back to remember and rewrite here/close.

kostasrim avatar Jan 27 '25 11:01 kostasrim