dragonfly icon indicating copy to clipboard operation
dragonfly copied to clipboard

end-to-end tests for ioredis and dragonfly

Open romange opened this issue 2 years ago • 6 comments

We already have pytests under tests/dragonfly.

I would like to add support for node-js tests. Specifically, start with ioredis tests.

Ideally, I would like to have the following deliverables:

  1. A script that automates local pipeline run - i.e. starts dragonfly binary using DRAGONFLY_PATH environment path, checks out https://github.com/luin/ioredis predefined tag (v5.2.3 and runs tests according to https://github.com/luin/ioredis/blob/main/.github/workflows/test.yml#L29
  2. a README.md that explains how to run the script and how to install the prerequisites. I do not know nodejs, so README should level with me :)
  3. Bonus: our own nodejs test that runs against a running dragonfly process (can start/stop using DRAGONFLY_PATH) and uncovers a specific scenario. For example, PUB/SUB use-case reported in #382 .

romange avatar Oct 12 '22 07:10 romange

I would recommend to use tedis

https://github.com/silkjs/tedis https://tedis.silkjs.org/

It has built in pooling, where the pools are dedicated connections.

It does not have memory leaks

It is simple and fast

Tomato6966 avatar Oct 13 '22 12:10 Tomato6966

Hey @Tomato6966 , the goal of end-to-end tests is to make sure that Dragonfly is compatible with the most popular client libraries. It's unrelated to the fact that other libraries may be better, of higher quality, and cetera.

romange avatar Oct 13 '22 12:10 romange

I will start working on this one!

gil-air-may avatar Oct 14 '22 02:10 gil-air-may

The tests are running locallly - thanks @gil-air-may ! Now, we just need to run them via the testing pipeline on github - depends on #291

romange avatar Oct 24 '22 13:10 romange

Cool, I'll give it a try this weekend!

gil-air-may avatar Oct 25 '22 03:10 gil-air-may

Hi everyone, I am new to coding and open source, how can I contribute here? I have beginner knowledge of C & C++.

Any help would be highly appreciated.

Thanks & Regards

imlishant avatar Jan 24 '24 11:01 imlishant