dragonfly icon indicating copy to clipboard operation
dragonfly copied to clipboard
verified publisher icon dragonflydb

chore(fakeredis): Enable JSON tests in the Fakeredis tests

Open BagritsevichStepan opened this issue 1 year ago • 3 comments

fixes dragonflydb#3671

  1. Fix the issue with the JSON.ARRINDEX command. It should return error for the empty result in the legacy mode
  2. Temporary disable filter expression tests in the test_json_arr_commands.py::test_arrindex
  3. Enable json fakeredis tests

BagritsevichStepan avatar Sep 23 '24 16:09 BagritsevichStepan

Can you please add a unit test for Fix the issue with the JSON.ARRINDEX command. It should return error for the empty result in the legacy mode ?

romange avatar Sep 23 '24 16:09 romange

Good work!

romange avatar Sep 23 '24 16:09 romange

Due to the fact that for jsonpathv2=true and jsonpathv2=false we get different error messages, I'm just checking in the test that we get an error.

The problem is mentioned in the #3777 issue. When it will be fixed, we will be able to check the error message in the tests.

BagritsevichStepan avatar Sep 25 '24 08:09 BagritsevichStepan