dragonfly icon indicating copy to clipboard operation
dragonfly copied to clipboard

deadlock when replicating from admin port

Open romange opened this issue 1 year ago • 2 comments

we have 100% reproducible deadlock bug when replica connects to a master via admin port.

the problem is that one of the commands in master (migrate) requires a listener to do the thread migration. We use hardcoded "main_listener" which is incorrect of course if we connect via admin.

I am going to fix a bug, but we need test coverage for admin port replication. Moreover, we need to scan where we use main_listener in the codebase and see if it makes sense for connections coming via admin_listener or uds listener etc

romange avatar Jun 22 '23 20:06 romange

I dont find from which flow we Call the DFLY THREAD command.. can you share where is this call coming from?

adiholden avatar Jun 25 '23 10:06 adiholden

we do not call it, it's a debug command for us to test thread/connections interactions.

romange avatar Jun 26 '23 08:06 romange